1861737 - Add support for "format" argument to browsingContext.captureScreenshot

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Via https://github.com/w3c/webdriver-bidi/pull/561 the format argument has been added to browsingContext.captureScreenshot. Tests will be synced via bug 1861653.

We should add this argument and support for all the image formats that we can support.

The related part of the HTML spec is at:
https://html.spec.whatwg.org/multipage/canvas.html#a-serialisation-of-the-bitmap-as-a-file

Comment 1

[Liam DeBeasi]

Attachment: Bug 1861737 - [webdriver-bidi] Support "format" argument in the "browsingContext.captureScreenshot" command.

Comment 2

[Liam DeBeasi]

Attachment: Bug 1861737 - [wdspec] Add tests for invalid types and values for the "format" argument in the "browsingContext.captureScreenshot" command.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1f9cbc68dc4
[webdriver-bidi] Support "format" argument in the "browsingContext.captureScreenshot" command. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/34c0ad83ab4e
[wdspec] Add tests for invalid types and values for the "format" argument in the "browsingContext.captureScreenshot" command. r=whimboo,webdriver-reviewers

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49732 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b1f9cbc68dc4
https://hg.mozilla.org/mozilla-central/rev/34c0ad83ab4e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Liam, thanks a lot for working on this new feature which will now be released in Firefox 135 early in February. Even through it was a bit more complicated (including the issues with hg) we hope you enjoyed and learned a lot. If you have further interests please let us know. Thanks!

Comment 8

[Liam DeBeasi]

Yeah this was great! I learned a lot. I'd be happy to help on anything else you may need.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Liam DeBeasi from comment #8)

Yeah this was great! I learned a lot. I'd be happy to help on anything else you may need.

Wonderful! Given that you already improved a lot I wonder if bug 1860955 might be a good thing for you to work on? Note that it would also require an update to the Python tests, if you don't mind that.

Comment 10

[Liam DeBeasi]

Hey there! Sorry, I thought I had replied already, but I guess not. Working on https://bugzilla.mozilla.org/show_bug.cgi?id=1860955 sounds good to me. I'm getting back up to speed post-holidays, so I'll take a look at this soon.