1861742 - Traverse ReadableByteStreamQueueEntry and PullIntoDescriptor instead of manual tracing

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

We won't need the "important:" warning comments that way.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1861742 - Part 2: Traverse ReadableByteStreamQueueEntry and PullIntoDescriptor r=evilpie,smaug

And also move the classes into cpp, because those are not being used elsewhere.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1861742 - Part 1: Move ReadableByteStreamQueueEntry and PullIntoDescriptor to cpp r=evilpie,smaug

They are not used by other files.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b3b79c88c5
Part 1: Move ReadableByteStreamQueueEntry and PullIntoDescriptor to cpp r=smaug
https://hg.mozilla.org/integration/autoland/rev/5acc492e809d
Part 2: Traverse ReadableByteStreamQueueEntry and PullIntoDescriptor r=smaug

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e5b3b79c88c5
https://hg.mozilla.org/mozilla-central/rev/5acc492e809d

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Quick question: Does this patch stack mean that we no longer need to have an explicit buffer clears here?

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #5)

Quick question: Does this patch stack mean that we no longer need to have an explicit buffer clears here?

Good question... Let me try removing it in a separate patch.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Comment on attachment 9360692 [details]
Bug 1861742 - Part 2: Traverse ReadableByteStreamQueueEntry and PullIntoDescriptor r=evilpie,smaug

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Crash fix
• User impact if declined: Users may experience unexpected crashes.
• Fix Landed on Version: 121.0a1
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only changes how JS objects are traced by following the well-established existing pattern.

Beta/Release Uplift Approval Request

• User impact if declined: (See the ESR request)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): (See the ESR request)
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Comment on attachment 9360979 [details]
Bug 1861742 - Part 1: Move ReadableByteStreamQueueEntry and PullIntoDescriptor to cpp r=evilpie,smaug

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9360979 [details]
Bug 1861742 - Part 1: Move ReadableByteStreamQueueEntry and PullIntoDescriptor to cpp r=evilpie,smaug

Approved for 120.0b7

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/aaa144e955c4
https://hg.mozilla.org/releases/mozilla-beta/rev/d2153f9936e9

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9360692 [details]
Bug 1861742 - Part 2: Traverse ReadableByteStreamQueueEntry and PullIntoDescriptor r=evilpie,smaug

Approved for 115.5esr.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/5397947a4d92
https://hg.mozilla.org/releases/mozilla-esr115/rev/6d6cf5177196