1861775 - Support for high-contrast freedesktop preference

Status: RESOLVED DUPLICATE of bug 1922872

(Core :: Widget: Gtk, enhancement, P3)

Description

[Dominic Hayes]

Steps to reproduce:

Using Firefox on any Linux-based OS with a Desktop Environment that provides a non-standardised high contrast value

Actual results:

Firefox doesn't enable its high contrast optimisations, despite technically having them in its code

Expected results:

I ended up making a merge request to xdg-portals to support letting applications know if the user prefers usage of High Contrast in applications. It has not been merged yet, and its design isn't fully finalised yet, but this bug report has been created to let Mozilla and other Firefox developers know about this merge request in hopes of allowing earlier preparation for Firefox's high contrast mode to support this preference, as well as serving as a bug to track progress on such support in the event the merge request in question is merged.

Here is the merge request: https://github.com/flatpak/xdg-desktop-portal/pull/1175

Comment 1

[Monica Chiorean]

I think the status of this enhancement should be new ?

Comment 2

[Monica Chiorean]

Marking as New since it is an enhancement.

Comment 3

[Daniel Bodea [:danibodea]]

Choosing the Disability Access component since this is related to High Contrast mode.

Comment 4

[Dominic Hayes]

https://github.com/flatpak/xdg-desktop-portal/pull/1175 is now merged. Therefore, there is now officially a contrast standard, so... ig bump...?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

This is not quite in the right component :)

The code to implement this would be around nsLookAndFeel::InitializeGlobalSettings (the color-scheme pref code can be an example).

Then we'd have to make this code do something like:

aResult = mPrefersContrastSetting.valueOr(mSystemTheme.mHighContrast);

Or something along those lines.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Hmm, maybe this is more of a "good second bug"... But happy to mentor in any case :)

Comment 7

[wilsu]

I'd be happy to accept the mentorship.
Looking at the code you've linked, it appears to already be doing "something like" aResult = mPrefersContrastSetting.valueOr(mSystemTheme.mHighContrast);:
nsLookAndFeel.cpp
I'm guessing I'd have to focus more on nsLookAndFeel::ComputeColorSchemeSetting?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I think this got done in bug 1922872.