1861910 - Some WPT failures of formatblock.html?4001-last are caused by wrong expectations

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Some tests expect "indeterm state", but expect specific `queryCommandValue" result.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

E.g.:

["<p>[foo<h1>bar]</h1>",
    [["defaultparagraphseparator","div"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"p",false,false,"div"],"formatblock":[true,false,"p",false,false,"div"]}],
["<p>[foo<h1>bar]</h1>",
    [["defaultparagraphseparator","p"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"div",false,false,"p"],"formatblock":[true,false,"p",false,false,"div"]}],
["<h1>[foo</h1><h2>bar]</h2>",
    [["defaultparagraphseparator","div"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"p",false,false,"div"],"formatblock":[true,false,"h1",false,false,"div"]}],
["<h1>[foo</h1><h2>bar]</h2>",
    [["defaultparagraphseparator","p"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"div",false,false,"p"],"formatblock":[true,false,"h1",false,false,"div"]}],
["<div>[foo</div>bar]",
    [["defaultparagraphseparator","div"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"p",false,false,"div"],"formatblock":[true,false,"div",false,false,"div"]}],
["<div>[foo</div>bar]",
    [["defaultparagraphseparator","p"],["formatblock","<div>"]],
    "<div>[foo</div><div>bar]</div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"div",false,false,"p"],"formatblock":[true,false,"div",false,false,"div"]}],

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1861910 - Make expected command value of "formatBlock" always empty string if expecting indeterm state r=m_kato!

If selections crosses multiple format block types,
Document.queryCommandIndeterm("formatBlock") should return true. In this
case, Document.queryCommandState("formatBlock") should always return ""
since the value is mixed, thus, indeterminable.

Depends on D192183

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/925231a8fb5e
Make expected command value of "formatBlock" always empty string if expecting indeterm state r=m_kato

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42960 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/925231a8fb5e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot