1861925 - Should be renamed from "ヤフオク!" to "Yahoo!オークション" ?

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Makoto Kato [:m_kato]]

I don't know who is current contract person for Yahoo! Japan and Mozilla's partner team. (I understand that Mozilla might have something affiliate contract with Yahoo! Japan).

Yahoo! Japan has new press release as https://auctions.yahoo.co.jp/topic/notice/other/post_3646/ that is their service name will be re-branded from "ヤフオク!" to "Yahoo!オークション" at November.

But https://searchfox.org/mozilla-central/source/browser/components/search/extensions/yahoo-jp-auctions/manifest.json still use "ヤフオク!". So I guess that we should rename it to "Yahoo!オークション" .

Comment 1

[Mark Banner (:standard8)]

I've confirmed that we should change this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1861925 - Rename Yahoo! auctions per their branding. r?#search-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e9da0fd4960
Rename Yahoo! auctions per their branding. r=search-reviewers,daleharvey

Comment 4

[Masatoshi Kimura [:emk]]

description still has the old brand name:
https://hg.mozilla.org/integration/autoland/rev/5e9da0fd4960#l1.7
Should it be "Yahoo!オークション 検索"?

Comment 5

[Masatoshi Kimura [:emk]]

See comment #4.

Comment 6

[Makoto Kato [:m_kato]]

Mark, I think that you should fix "description" too. description is still "ヤフオク! 検索". It should be "Yahoo!オークション 検索".

Comment 7

[Mark Banner (:standard8)]

You're right that I missed the description, however that isn't actually displayed anywhere, and will likely be going away soon, so I think we can leave it for now.

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1861925 - Rename Yahoo! auctions per their branding. r?#search-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D192893

Comment 9

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1861925 - Rename Yahoo! auctions per their branding.

Original Revision: https://phabricator.services.mozilla.com/D192893

Comment 10

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• Is Android affected?: no
• Code covered by automated testing: yes
• Needs manual QE test: no
• Explanation of risk level: Simple branding update
• User impact if declined: None - Branding update
• Fix verified in Nightly: no
• String changes made/needed: None
• Steps to reproduce for manual QE testing: Install a ja build & run it and check search engines.

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 1861925 - Rename Yahoo! auctions per their branding.

Original Revision: https://phabricator.services.mozilla.com/D192893

Comment 12

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• Is Android affected?: no
• Code covered by automated testing: yes
• String changes made/needed: None
• Steps to reproduce for manual QE testing: Install a ja build & run it and check search engines.
• Explanation of risk level: Simple branding update
• Needs manual QE test: no
• User impact if declined: None - Branding update
• Fix verified in Nightly: no

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 9362527 [details]
Bug 1861925 - Rename Yahoo! auctions per their branding.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Branding change for a search engine partner
• User impact if declined: None
• Fix Landed on Version: 121
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple name change.

Note: this is manually requested ESR because moz-phab uplift is broken when I try uplifting to ESR.

Comment 14

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5e9da0fd4960

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9362527 [details]
Bug 1861925 - Rename Yahoo! auctions per their branding.

Approved for 120.0b9

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/38f3cd5c2a42

Comment 17

[Dianna Smith [:diannaS]]

Comment on attachment 9362527 [details]
Bug 1861925 - Rename Yahoo! auctions per their branding.

Approved for 115.5esr

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/7a8d98fcc482

Comment 19

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx120.0b9 and Fx121.0a1 on WIndows 10 and Ubuntu 20.04. Yahoo engine name is now: "Yahoo!オークション".
Will verify the ESR jp locale as soon as it's available.

Comment 20

[Cristian Baica [:cbaica], Release Desktop QA]

Teste the ESR build as well. Yahoo search engine is now correctly named as listed in the description.