Closed Bug 1862012 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42845 - [wdspec] rewrite remove network interception tests to fail gracefully

Categories

(Remote Protocol :: WebDriver BiDi, task, P4)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task

Tracking

(firefox122 fixed)

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42845 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42845
Details from upstream follow.

Thiago Perrotta <tperrotta@chromium.org> wrote:

[wdspec] rewrite remove network interception tests to fail gracefully

  • Use navigation with an expected timeout instead of fetch with an expected exception.

From a test implementation perspective this is a no-op as, when the network interception triggers, the navigation is expected to not complete (and thus timeout).

  • Introduce a "wait_for_future_safe" fixture that gracefully fails the await of a future instead of making the whole test suite fail.

Instead of aborting the "wpt run" when there is a timeout, treat the timeout as a failure, effectively failing gracefully. This allows subsequent tests to run, and expectations to be updated later on.

Related: https://github.com/w3c/webdriver-bidi/issues/188

Bug: #42482

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Component: web-platform-tests → Marionette
Product: Testing → Remote Protocol
Component: Marionette → WebDriver BiDi
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2bf41ffde4b [wpt PR 42845] - [wdspec] rewrite remove network interception tests to fail gracefully, a=testonly https://hg.mozilla.org/integration/autoland/rev/ed73bd0bca88 [wpt PR 42845] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd47cb42662e [wpt PR 42845] - [wdspec] rewrite remove network interception tests to fail gracefully, a=testonly https://hg.mozilla.org/integration/autoland/rev/e20836430d51 [wpt PR 42845] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cd47cb42662e
https://hg.mozilla.org/mozilla-central/rev/e20836430d51

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.