Closed Bug 1862061 Opened 8 months ago Closed 8 months ago

Remove -moz-font-smoothing-background-color

Categories

(Core :: Widget: Cocoa, task)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Per discussion with mstange:

  • macOS stopped doing subpixel AA with 10.14*
  • We only run on 10.15 and above.
  • There used to be the option to re-enable it with defaults write -g CGFontRenderingFontSmoothingDisabled -bool false, but that option was removed in Big Sur.

so the only mac configuration we support which still has subpixel AA is 10.15 with that non-standard pref set which is not worth caring about

Seems we can remove that code.

Some other potentially-useful-in-the-future discussion:

mstange: unless... we may want to use it for vibrancy on Windows?
emilio: perhaps? I'm not sure there are concrete plans for that, do you know?
mstange: no I don't know of any plans
emilio: I know about the mica titlebar stuff which I hacked up a bit ago, but other than that we don't support glass anymore
mstange: yes that's what I was thinking of
emilio: mstange: is it not an issue for websites btw? Think a backdrop-filter with text inside
emilio: Maybe we just disable subpixel AA there?
emilio: And maybe that's fine nowadays ;)
mstange: that's right, yeah websites just get grayscale AA there
emilio: Cool, okay, I'll remove then for now. If we want to fix that problem more generally we can resurrect that code, or do something smarter (just using a reasonable guess based on the color-scheme of the element might be an ok thing to do for chrome code actually)

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

See comments in the bug for reasoning. macOS hasn't used subpixel AA for
quite a while.

Emulating this macOS AA on vibrant backgrounds was the only point of
this feature.

This allows to simplify the WebRender code quite a bit, too.

Depends on D192103

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac21868e42ba
Remove -moz-font-smoothing-background-color. r=gfx-reviewers,desktop-theme-reviewers,devtools-reviewers,dao,gw
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/119e115b8bff
remove Thunderbird usage of -moz-font-smoothing-background-color. r=me
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: