1862208 - Matrix messages aren't shown anymore

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Martin Giger [:freaktechnik]]

The de-XPCOM caused matrix prepareForDisplaying code break because it assumed things would be XPCOM wrapped, when they aren't. The function call then errors which leads to us never displaying the message.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1862208 - Fix display of Matrix messages. r=clokep

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0fe2ff39512
Fix display of Matrix messages. r=clokep

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9361198 [details]
Bug 1862208 - Fix display of Matrix messages. r=clokep

[Approval Request Comment]
Regression caused by (bug #): bug 1857959
User impact if declined: Can not see any matrix text messages
Testing completed (on c-c, etc.): Tested on c-c, new automated test covering the issue.
Risk to taking this patch (and alternatives if risky): Low risk, only modifies matrix protocol which is already not working in a useful way.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9361198 [details]
Bug 1862208 - Fix display of Matrix messages. r=clokep

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 120.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/8d698fdcf247