Closed Bug 1862293 Opened 2 years ago Closed 1 year ago

Translations UI Integration Integrate Download Languages - Global Settings

Categories

(Firefox for Android :: Translations, enhancement, P3)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- verified

People

(Reporter: olivia, Assigned: giorga)

References

Details

(Whiteboard: [fxdroid][foundation][translations:128])

Attachments

(2 files)

This bug is for integrating the download language page.

Relevant Figma.

Dependencies:

Severity: -- → N/A
Depends on: 1855980, 1855976
Priority: -- → P3
Whiteboard: [fxdroid][foundation]
Summary: Translations UI Integration Integrate Download Languages → Translations UI Integration Integrate Download Languages - Global Settings
Depends on: 1876820
Whiteboard: [fxdroid][foundation] → [fxdroid][foundation][translations:128]
Depends on: 1881810
Assignee: nobody → giorga
Depends on: 1898358
Attachment #9403492 - Attachment description: WIP: Bug 1862293 - Translations UI Integration Integrate Download Languages - Global Settings → Bug 1862293 - Translations UI Integration Integrate Download Languages - Global Settings
Blocks: 1900152
Pushed by giorga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/179b4068029a Translations UI Integration Integrate Download Languages - Global Settings r=android-reviewers,ohall
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Flags: qe-verify+

Hi QE,

Thanks for taking a look! Please also check a few locales on this change too. There are some differences between locales that require pivots (non-English) and an English locale.

Please verify behavior against:

  • English as the app locale
  • A language in the translation options that is not English as the app locale
  • A language not in the translation options as the app locale

When changing locales, it will be necessary to fully close the app and open again to pull new download information.

Expected differences:

  • Download sizes will generally be different between locales
  • The name of the current locale, if applicable, will not be in the list of languages (e.g., on a French app locale, French will not appear in the list of downloadable languages because it is implicitly downloading to French)
  • Changing between locales will sometimes impact the download state. For example, on an English locale app, French is downloaded when FR->EN and EN->FR are available. However, if the locale is switched to German, then FR->EN, EN->FR, DE->EN and EN->DE are required. So the completed download state will shift depending on the language changes.

We have some scheduled follow-ups to update TalkBack bug 1900152, the English sync state should also occur the first time any language is downloaded on a non-English locale bug 1900148 (because English is the pivot language), and potentially a bug for when downloading all languages that has not been filed.

Verified on the latest Fenix Nightly 128.0a1 from 6/6 with a Google Pixel 6 (Android 14) the following:

  • downloading all languages does not work as expected - filed Bug 1900971;
  • when the device is set to a different language then English, like French, the French language is not displayed anymore in the "Download languages" list;
  • setting the device in a language that is not supported for translation, like Romanian, correctly detects the page's language,
  • changing the locale of the device displays different download sizes - please see the attached screenshot.

The "Delete all languages" option is not working properly yet - filed Bug 1900974.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: