1862437 - ATK's GetColumnRowSpanCB should not set the row extent to the col extent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

Looks like a C&P error that's been around a while....

https://hg.mozilla.org/mozilla-central/file/tip/accessible/atk/nsMaiInterfaceTableCell.cpp#l64

  *aColExtent = static_cast<gint>(cellAcc->ColExtent());
  *aRowExtent = static_cast<gint>(cellAcc->ColExtent());

One can get the spans separately as GetRowSpanCB is right, but getting them at once is preferable. Please and thank you. :)

Comment 1

[James Teh [:Jamie]]

Urgh. It looks like this has been around since this interface was implemented back in 2016. However, I think it got worse with bug 1821957 (Firefox 115). Before that, this bug only applied to content hosted in the parent process (Firefox UI). After that, it began to apply to (remote) web content as well.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1862437: Return the correct data for ATK get_row_column_span.

Previously, this incorrectly returned the row in the column field, the column in the row field, and the column span for both the row and column spans.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0998094bd9
Return the correct data for ATK get_row_column_span. r=eeejay

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cf0998094bd9