Closed
Bug 1862504
Opened 1 year ago
Closed 1 year ago
AudioConverter.cpp: do not use 'else' after 'return'
Categories
(Core :: Audio/Video, task)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: cmj.grubb, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/dom/media/AudioConverter.cpp#78-87
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Updated•1 year ago
|
Assignee: nobody → cmj.grubb
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e45c0f9422db
Removed 'else' after 'return' for code readability. r=alwu,sylvestre
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•