1862568 - In full screen, using 'Forget' in toolbar causes Firefox to exit full screen

Status: NEW

(Firefox :: Toolbars and Customization, defect, P5)

Description

[OpenContributor]

Attachment: forgetExitFullScreen.mov

Affected versions

• Firefox 119.0

Affected platforms

• macOs 12.5.1

Preconditions

• Firefox in full screen

Steps to reproduce

1. Click the 'Open application menu' button
2. Click the 'More tools' button
3. Click the 'Customize toolbar...' button
4. Drag 'Forget' to the toolbar
5. Click the 'Forget'
6. Click the 'Forget!' button

Expected result

• Firefox doesn't exit the full screen

Actual result

• Firefox exits the full screen

Comment 1

[BugBot [:suhaib / :marco]]

:opencontributor0304, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[:Gijs (he/him)]

There appears to be macOS-specific fullscreen exiting code at https://searchfox.org/mozilla-central/rev/6f0792f9f3f1a6175ce1f8e318a8a0f51ba76dee/browser/modules/Sanitizer.sys.mjs#628-641 and I do not understand why; hg annotate suggests it was added in https://hg.mozilla.org/mozilla-central/rev/9a6d45264eb260789068d0e6a19bcffff1d1d16b for bug 1089695 but there's no record of any discussion around this.