186257 - Creation of XMLRPC string broken.

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Ami Ganguli]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20021217

Creating a XMLRPC call with a string parameter fail, throwing an exception here:

obj=obj.QueryInterface(Components.interfaces['nsISupports' + sType]);

sType should be "CString", but in fact it's "String".  The value originates from
the _typeOf method.


Reproducible: Always

Steps to Reproduce:




I'm still fumbling around trying to figure out how things work, but this appears
to be the fix:

--- mozilla-20.12.2002/extensions/xml-rpc/src/nsXmlRpcClient.js Wed Dec  4
09:59:57 2002
+++ mozilla/extensions/xml-rpc/src/nsXmlRpcClient.js    Fri Dec 20 10:52:40
2002@@ -476,7 +476,7 @@
                 break;
  
             case 'Char':
-            case 'String':
+            case 'CString':
                 obj=obj.QueryInterface(Components.interfaces['nsISupports' +
                     sType]);
                 writer.startElement('string');
@@ -586,7 +586,7 @@
          
         try {
             obj.QueryInterface(Components.interfaces.nsISupportsCString);
-            return 'String';
+            return 'CString';
         } catch(e) {}
          
         try {

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Samuel is the owner of XML-RPC, reassigning.

Comment 2

[Samuel Sieb]

Attachment: fix strings

Sorry for the delay.  I thought I had fixed all the string breakage.

Comment 3

[Darin Fisher]

Comment on attachment 116407 [details] [diff] [review]
fix strings

rs=darin

Comment 4

[Samuel Sieb]

Checked into the trunk.

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

If this landed, this can then be marked fixed, so doing that now.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 116407 [details] [diff] [review]
fix strings

a=asa (on behalf of drivers) for checkin to 1.3 branch.

Comment 7

[Samuel Sieb]

checked into branch