1862740 - network/sctp: Follow-up style guide fixes

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Victor Boivie]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36

Steps to reproduce:

This is a follow up from bug 1859759 to fix some remaining style guide fixes, mainly

• Following the style guide wrt declaration order.
• Use const whenever it makes sense.
• Move members to be private where possible (e.g. mLock was previously public, which it didn't have to be).
• Fix most compiler warnings.

Comment 1

[Victor Boivie]

Attachment: Bug 1862740: Misc c++ style fixes

Including, but not limited to:

• Following the style guide wrt declaration order.
• Use const whenever it makes sense.
• Move members to be private where possible (e.g. mLock was previously public,
  which it didn't have to be).
• Replaced DataChannel::mFlags with individual bools - easier to read.
• Fix most compiler warnings.

These kind of changes are rarely complete - there is always something that was
missed. It's still a step in the right direction.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3486a52197d1aa31451ff237c7d74d2b972e9098
https://treeherder.mozilla.org/jobs?repo=try&revision=98b5c652c894f716c53c99e10b41748f16a17b9d
https://treeherder.mozilla.org/jobs?repo=try&revision=b4ef62770e01a9e6943b9e6b96e2ce9102dd578e

Comment 3

[Byron Campen [:bwc]]

Try looks fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f299fbf0c989
Misc c++ style fixes r=bwc

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f299fbf0c989