1862982 - The "Cookie Banner Blocker" buttons from the Protections panel are off center

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

[Affected versions]:

• Firefox Beta 120.0b5 - Build ID: 20231101092803
• Firefox Nightly 121.0a1 - Build ID: 20231103093836

[Affected Platforms]:

• Windows 10 x64
• macOS 14.0

[Prerequisites]:

• Have the cookiebanners.service.mode.privateBrowsing pref set to 1 on a new profile.

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Navigate to cnn.com.
3. Click the shield icon from the address bar.
4. Click the "Cookie Banner Blocker" option from the dropdown.
5. Observe the Turn Off/On and Cancel buttons.

[Expected result]:

• The button labels are centered in the button.

[Actual result]:

• Beta: Both button labels are off center and are placed higher in the button when compared to similar buttons.
• Nightly: The Cancel button is off center and is placed higher in the button than the Turn Off/On one.

[Notes]:

• Attached screenshots of the issue.
• The issue is either not reproducible on Linux or it's not very visible.

Comment 1

[Emma Zühlcke [:emz]]

DJ, could you take a look please? Curious if this is a regression.

Comment 2

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Regression window:

6:22.79 INFO: Last good revision: 0c6d0f8aa20d250dcd1a3169f8926c33b95851f8
6:22.79 INFO: First bad revision: 77fcb77e6acc925c7607c4bf3f7e84ca6962ed9e
6:22.79 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c6d0f8aa20d250dcd1a3169f8926c33b95851f8&tochange=77fcb77e6acc925c7607c4bf3f7e84ca6962ed9e

This is where we went from labels centered in the buttons to both being off center.

3:12.54 INFO: First good revision: d6364ec2060b8b6c1ad1b9be552242c7f520816b
3:12.54 INFO: Last bad revision: 0d9fd834642ac8f80ee1c85f1a292341e18dacbc
3:12.54 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0d9fd834642ac8f80ee1c85f1a292341e18dacbc&tochange=d6364ec2060b8b6c1ad1b9be552242c7f520816b

And here is where we went from both buttons being off center to just one.

I'll mark bug 1838939 as the regressor and add the other one to see also.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1838939

Comment 4

[DJ]

Attachment: Bug 1862982 - fix fluent schema for cookie banner blocker cancel button. r?#fluent-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dde4a845d483
fix fluent schema for cookie banner blocker cancel button. r=fluent-reviewers,bolsson

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/dde4a845d483

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Firefox Release 121 (BuildID 20231211174248) and on the latest Firefox Nightly 123.0a1 (BuildID 20231219231600) using Windows 10 and macOS 14.1.1.