1863006 - Display selector warnings in Rules view

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P2)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

MDN might have dedicated pages for the issue (e.g. unconstrained :has perf warning might be documented https://github.com/mdn/mdn/issues/469)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1863006 - [devtools] Tweak css classes for rules view selectors. r=#devtools-reviewers.

This will be used to have a common class we can target between the rule selector
and the ones in ancestor data (next patch in queue)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1863006 - [devtools] Return selectors array for ancestor rules. r=#devtools-reviewers.

We used to return selectorText for those, but we want to have individual elements
for each selectors so we can put selector warnings icon next to the right selector.

Depends on D192864

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1863006 - [devtools] Display selector warnings in Rule view. r=#devtools-reviewers.

For now this only handles UnconstrainedHas warnings, but we may have more
in the future.

Depends on D192865

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc98109f1857
[devtools] Tweak css classes for rules view selectors. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/c8b60425f0a2
[devtools] Return selectors array for ancestor rules. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/a4657a05cffd
[devtools] Display selector warnings in Rule view. r=devtools-reviewers,fluent-reviewers,ochameau.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cc98109f1857
https://hg.mozilla.org/mozilla-central/rev/c8b60425f0a2
https://hg.mozilla.org/mozilla-central/rev/a4657a05cffd