1863088 - Timeout in toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html in M-xorig

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect, P1)

Description

[[:owlish] 🦉 PST]

This test fails on all Android builds with both isolateEverything and isolateHighValue isolation strategies (fission.webContentIsolationStrategy set to 1 or 2 respectively).

Failures:

[task 2023-11-03T20:29:25.869Z] 20:29:25     INFO -  TEST-START | toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html
[task 2023-11-03T20:34:28.540Z] 20:34:28  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html | Test timed out. -
[task 2023-11-03T20:34:28.540Z] 20:34:28  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2023-11-03T20:34:28.540Z] 20:34:28     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2023-11-03T20:34:28.540Z] 20:34:28     INFO -      afterCleanup@SimpleTest/SimpleTest.js:1477:18
[task 2023-11-03T20:34:28.540Z] 20:34:28     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1562:7
[task 2023-11-03T20:34:28.541Z] 20:34:28     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1582:3
[task 2023-11-03T20:34:28.541Z] 20:34:28     INFO -      @SimpleTest/SimpleTest.js:2265:16
[task 2023-11-03T20:34:28.541Z] 20:34:28     INFO -      async*@SimpleTest/SimpleTest.js:2262:17

example try push
logcat from that try push

Comment 1

[[:owlish] 🦉 PST]

Hey calixte, do you know what might be going on here?

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1863088 - Fix timeout in test_pdf_file_in_iframe.html in M-xorig r=owlish

Comment 3

[Calixte Denizet (:calixte)]

An await is missing here:
https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/content/GeckoViewPdfjsParent.sys.mjs#353
but unfortunately, this isn't enough to fix the issue.
When we're getting Nimbus data, we send a message to the parent, then it gets the data, send them to the child and the child notifies an observer to send them to the content process.
For any reason, when the test is ran with --enable-xorigin-tests, the observer doesn't receive the notification:

• https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/content/GeckoViewPdfjsChild.sys.mjs#41
• https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/content/PdfStreamConverter.sys.mjs#318-323

The test works correctly on Android without the above option and on desktop with/without the option.

:owlish, do you know what's wrong here ? or do you know who could help me to figure out what's wrong ?

Comment 4

[Calixte Denizet (:calixte)]

I found what's wrong.
Here:
https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/content/GeckoViewPdfjsParent.sys.mjs#341-344
we must use sendAsyncMessage to send a message the child actor, right now a new pair of actors is created which is wrong.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9850dc0fc070
Fix timeout in test_pdf_file_in_iframe.html in M-xorig r=owlish

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9850dc0fc070