1863110 - If trimHttps is enabled, domain highlighting is not applied when loading suggested bookmark

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[6k64x4ma]

Attachment: screenshot.webp

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

1. Set browser.urlbar.trimHttps to true.
2. Open a new tab.
3. Type something in the address bar and select suggested bookmark.

Actual results:

• The whole address is highlighted.

Expected results:

• Only the domain name should be highlighted.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mseibert, since you are the author of the regressor, bug 1067293, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on:

• Firefox 119.0;
• Firefox 120.0b6;
• Nightly 121.0a1;

Tested and reproduced on:

• Windows 10;
• Ubuntu 22;
• macOS 12;

Setting as NEW so the developing team can have a look.

Comment 3

[6k64x4ma]

Corrected steps to reproduce:

1. Set browser.urlbar.trimHttps to true.
2. On any tab, type something in the address bar.
   At this time, the auto-completed URL must be displayed.
3. Select suggested bookmark.

Comment 4

[Marc Seibert (:mseibert)]

Attachment: Bug 1863110 - If trimHttps is enabled, domain highlighting is not applied when loading suggested bookmark.r=dao

Depends on D192696

Comment 5

[Marc Seibert (:mseibert)]

This is a result of two things:

1. We don't format urls, when they don't start with a valid scheme (and slashes).
2. We don't reformat, when _urlMetaData already contains the value of the urlbar.

For some reason the trimmed URL is placed in the meta data object. This in turn is compared to the trimmed value of the Urlbar. As a result no reformatting happens.

I created a patch that fixes the problem, but I can't write a test case as of now, because I don't know why it happens.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1067293

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5d904bee3fe
If trimHttps is enabled, domain highlighting is not applied when loading suggested bookmark.r=dao

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f5d904bee3fe

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-11-03 Nightly build on macOS 12.
Verified as fixed on Firefox Nightly 122.0a1 on macOS 12, Windows 10, Ubuntu 22.