1863217 - window.open() Popup is blocked when called from a user interaction event

Status: NEW

(Core :: DOM: Events, defect)

Description

[nadeem]

Attachment: page.html

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

See the attachment html file for a demo.

1. Create a button in an html page with an async "click" event handler.

2. In the button "click" event handler, create a message listener using window.addEventListener( "message",..) and wait for one message to come using a promise as the following
   // Wait for an incoming message
   await new Promise((res, rej) => {
   // Wait for a message
   window.addEventListener(
   "message",
   function handler(event) {
   console.log('received message', event);
   window.removeEventListener("message", handler, false);
   res();
   },
   false,
   );
   });

3. Send a message to unblock the listener. This could inside or outside the click event handler: setTimeout(window.postMessage('message'), 100);

4. Call window.open() inside the handler as soon as a message is received

Actual results:

The pop-up is blocked and I see the Firefox warning "Firefox prevented this site from opening a pop-up window."

Technical Notes:
It seems the PopupBlocker component is using the "message" event, which is a disallowed event instead of considering the click event though the window.open was not called from the message handler itself.

Expected results:

The pop-up is opened and without a warning.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Events' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Oliver, would you want to investigate this a bit and see how this relates with the pop-up user activation model work you're working on?

Comment 3

[Oliver Medhurst [:canadahonk]]

This looks like it would be fixed by the popup blocker moving to using the user activation model, I'm guessing the reason this doesn't currently work is the popup blocker is quite tied to specific events unlike the user activation model which should allow 1 popup if there's an active (last 3s) user activation (eg click).

Comment 5

[Edgar Chen [:edgar]]

This is the same root cause as bug 1739655.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1863217 - Do not propagate the popup state to microtask;

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=eadfbfb477ff95d1cea74bbc75a497059754b6d4

Comment 8

[Edgar Chen [:edgar]]

(Perhaps we could consider falling back to check user activation when popup state is openBlocked, see bug 1894244 comment 2, which could also fix this, too)

Comment 9

[Edgar Chen [:edgar]]

(Let's wait for bug 1894244 and revisit this)