Make Web Locks tests deal with promise argument conversion as defined in the WebIDL spec
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: peterv, Assigned: peterv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Some Web Locks wpt tests release locks from a cleanup task, but they don't wait until the lock is actually released. The tests currently pass, because in most browser engine implementations the promise that's returned from the callback for these locks is incorrectly converted by just keeping the original promise. The WebIDL spec actually requires the conversion to create a new promise around the returned promise, which means the release requires another microtask. If we fix implementations to follow the WebIDL spec then we'll start the next test before the locks from the previous test are released, causing havoc.
|
Assignee | |
Comment 1•7 months ago
|
||
Some Web Locks wpt tests release locks from a cleanup task, but they don't wait
until the lock is actually released. The tests currently pass, because in most
browser engine implementations the promise that's returned from the callback for
these locks is incorrectly converted by just keeping the original promise. The
WebIDL spec actually requires the conversion to create a new promise around the
returned promise, which means the release will require another microtask. If we
fix implementations to follow the WebIDL spec then we'll start the next test
before the locks from the previous test are released, causing havoc.
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b10b3c0867f6 Make Web Locks tests deal with promise argument conversion as defined in the WebIDL spec. r=saschanaz
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42967 for changes under testing/web-platform/tests
|
||
Comment 4•7 months ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
Description
•