Can't add DOM-Modification breakpoints after a reload; they fail with `TypeError: can't access property "update", container is undefined` in Browser Console
Categories
(DevTools :: Inspector, defect, P2)
Tracking
(firefox-esr115 wontfix, firefox119 wontfix, firefox120 wontfix, firefox121 verified)
People
(Reporter: dholbert, Assigned: nchevobbe)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
STR:
- Visit http://example.org/ (or probably any site)
- Right-click some blank area, Inspect
- In the inspector, right click
<html>and choose "Break on: Attribute Modification" - Verify that step 3 made a difference -- right-click
<html>again, and choose "Break on", and verify that "Attribute Modification" is shown checked. (Also, an arrow/label should be to the left of the html element in the inspector) - Ctrl+R to reload the page (keeping devtools inspector open)
- Repeat steps 3 and 4.
ACTUAL RESULTS:
The "Break on: Attribute Modification" function stops working (i.e. it has no effect). It seems that it becomes broken and stays broken (i.e. I can't watch attribute modifications) after I reload. If I check Browser Console (ctrl shift J), I see the following error appear when I click "Break on: Attribute Modification" (in step 5, i.e. after the previous successful watchpoint + reload):
TypeError: can't access property "update", container is undefined markup.js:467:7
which points to this line.
EXPECTED RESULTS:
No TypeError; the breakpoint should be successfully added.
Note: if I close and reopen devtools, then the issue seems to go away.
|
Reporter | |
Comment 1•2 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
I see the following error [...] which points to this line.
Looks like this is a regression from the bug that added that line, bug 1581213.
Last good Nightly: 2022-10-26
First bad Nightly: 2022-10-27
Regression pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ab716c244f85daccb19bf580c59caf3db4a4b37f&tochange=2dddf127c6ab66595268672db7088712f1322aff
...which includes bug 1581213.
|
|
Reporter | |
Comment 2•2 years ago
|
||
(Author on that bug hasn't been active on Bugzilla for a while. jdescottes, maybe you could take a look here? Maybe this might be as simple as adding a null-check or something?)
|
||
Comment 3•2 years ago
|
||
Set release status flags based on info from the regressing bug 1581213
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 5•2 years ago
|
||
DOM mutation breakpoints are set on specific node fronts,
and we would keep retrieving node fronts from now discarded
targets after the page navigated.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
|
||
Comment 8•2 years ago
|
||
The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox120towontfix.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 9•2 years ago
|
||
(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #8)
The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox120towontfix.For more information, please visit BugBot documentation.
the issue exists for a while already, and we're at the end of the cycle, so let's not uplift
|
||
Updated•2 years ago
|
|
||
Comment 10•2 years ago
|
||
Reproduced this issue on an affected Nightly build from 2023-11-06, on Ubuntu 22 following the STR from Comment 0.
Verified as fixed on Firefox 121.0b4 (20231127091758) on Ubuntu 22, macOS 11 and Windows 10. The breakpoint is successfully added and no TypeError is seen in the Browser Console.
Description
•