1863421 - Table fragmentation wrongly reserves space for border-spacing and border

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Testcase #1

Steps to reproduce:

1. Load the testcase #1 attached.
2. Open print-preview.

There shouldn't be any border-spacing added to the content area at the bottom of the first page and the top of the second page.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Testcase #1 on Firefox 121 (wrong).png

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Testcase #1 on Chrome 120 (correct).png

Comment 3

[Daniel Holbert [:dholbert]]

We've got the same bug here just for border, FWIW (no border-spacing required). i.e. if you view the attached testcase and un-tick border-spacing rule, Firefox still reserves space at the bottom of the first page and the top of the second page, even though we don't actually draw a table-border there.

(Chrome does not reserve that space; and we don't do that for equivalent scenarios with just blocks. So it's pretty-clearly wrong. Though it would be correct in a box-decoration-break:clone situation.)

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1863421 Part 1 - Stop reserving row-spacing at the block-start edge in table continuations.

The testcases in our own reftest frameworks are modified to reflect the current
rendering. The main difference after this patch is that we don't apply row
spacing at the block-start edge in the table continuations.

Depends on D195332

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1863421 Part 2 - Add web-platform-tests for table printing.

Depends on D195333

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1863421 Part 3 - Add more web-platform-tests for table printing.

In Part 2, we add "a" variant to exercise auto block-size on table elements.

This patch adds other variants.

• "b" variant exercises fixed block-size on table elements.
• "c" variant exercises auto block-size and box-decoration-break:clone on
  table elements.
• "d" variant exercises fixed block-size and box-decoration-break:clone on
  table elements.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98473d4fe576
Part 1 - Stop reserving row-spacing at the block-start edge in table continuations. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/a831daee712b
Part 2 - Add web-platform-tests for table printing. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/994242ac700d
Part 3 - Add more web-platform-tests for table printing. r=layout-reviewers,emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44953 for changes under testing/web-platform/tests

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/98473d4fe576
https://hg.mozilla.org/mozilla-central/rev/a831daee712b
https://hg.mozilla.org/mozilla-central/rev/994242ac700d

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ea75ed91b67
for causing unexpected passes on table-nested-1308876-1.xhtml CLOSED TREE

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1ea75ed91b67

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-03-05 Nightly build on macOS 12.
Verified as fixed on Firefox Nightly 126.0a1 and Firefox 125.0b4 on macOS 12, Windows 10, Ubuntu 22.