Closed
Bug 1863472
Opened 2 years ago
Closed 2 years ago
Pseudo class in selector (e.g. :hover) does not have enough contrast in light mode
Categories
(DevTools :: Inspector: Rules, defect, P2)
DevTools
Inspector: Rules
Tracking
(firefox121 fixed)
RESOLVED
FIXED
121 Branch
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
|
Bug 1863472 - [devtools] Fix contrast for light mode pseudo-class lock color. r=#devtools-reviewers.
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
| Assignee | ||
Comment 1•2 years ago
|
||
yellow-70 was not contrasted enough on white background,
but yellow-80 was a bit too dark, so we add a yellow-75
that was interpolated from yellow-70 and yellow-80.
The same colors were used for the breadcrumb and the
selector, but with different variables.
We clean this up by defining a single variable that
we can use in both location.
The new color also has enough contrast when the selector
is highlighted (by a search) in the rules view.
Depends on D192553
Updated•2 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30d4156d4c46
[devtools] Fix contrast for light mode pseudo-class lock color. r=devtools-reviewers,ochameau.
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox121:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•