moz-phab on a git repo should use HEAD when git-cinnabar isn't available
Categories
(Conduit :: moz-phab, enhancement)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Unassigned)
References
(Blocks 1 open bug)
Details
with git clone https://github.com/mozilla/gecko-dev && cd gecko-dev
I made some changes, I tried to push them to phabricator with:
$ moz-phab submit tip
Git Cinnabar extension is required to work on this repository.
According to Glandium, this is failing because moz-phab can't find the reference commit:
moz-phab needs the sha1 hg and for this, needs git-cinnabar
If git-cinnabar can't be found, maybe we should display a warning and use HEAD instead.
As having git-cinnabar simplifies other repository actions it's considered mandatory; this is called out as required in our documentation.
While it's probably technically possible to implement some workarounds in moz-phab, we're likely to only be able to support the simplest of cases. Given the workaround (install cinnabar as per the docs), this isn't something we should fix.
|
||
Comment 2•6 months ago
|
||
I believe this is fixed as of bug 1963801. Not having git-cinnabar is now just a warning even if the local VCS and remote VCS don't match.
Description
•