1863482 - Don't duplicate relation definitions

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

Currently, we have to define relations in both accessible/base/RelationType.h and accessible/interfaces/nsIAccessibleRelation.idl and ensure they are kept in sync. We even duplicate the comments. Similar to bug 1844238 for roles, we should generate the .h from the .idl to avoid duplication.

Comment 1

[James Teh [:Jamie] (away returning 28 Jan)]

Attachment: Bug 1863482 part 1: Change includes of RelationType.h to mozilla/a11y/RelationType.h.

RelationType.h will soon be generated, but it will be generated within the obj dir, so local includes won't work.
Our C++ style guide says we should prefer exported includes wherever possible anyway.

This was done with this shell command inside the accessible/ directory:

sed -i 's,#include "RelationType.h",#include "mozilla/a11y/RelationType.h",' `git grep -l '#include "RelationType.h"'`

Comment 2

[James Teh [:Jamie] (away returning 28 Jan)]

Attachment: Bug 1863482 part 2: Generate RelationType.h from nsIAccessibleRelation.idl.

This eliminates duplication.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5289d2893a5
part 1: Change includes of RelationType.h to mozilla/a11y/RelationType.h. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/b6c4e5d85bca
part 2: Generate RelationType.h from nsIAccessibleRelation.idl. r=eeejay

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a5289d2893a5
https://hg.mozilla.org/mozilla-central/rev/b6c4e5d85bca