1863534 - Remove RTCRtpEncodingParameters.ssrc/fec/rtx

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Description

[Byron Campen [:bwc]]

These have never done anything in Firefox, and aren't in webrtc-pc or webrtc-extensions. @jib, is it likely that these will be in any specification anytime soon?

Comment 1

[Byron Campen [:bwc]]

^

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

No, we should just remove them.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Moreover, we generally want to only include in WebIDL what we actually implement, to not hide tech debt. We appear to support:

transceiver.sender.getParameters() = {
  "codecs": [],
  "headerExtensions": [],
  "rtcp": {
    "cname": "",
    "reducedSize": false
  },
  "encodings": [
    {
      "active": true,
      "maxBitrate": 50000,
      "maxFramerate": 30,
      "priority": "low",
      "rid": "a",
      "scaleResolutionDownBy": 2
    }
  ],
  "transactionId": "{d615ca54-5ba0-4415-bf8c-d6ef26d7e928}"
}

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1863534: Remove RTCRtpEncodingParameters.ssrc/rtx/fec. r?jib

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c830bff0857
Remove RTCRtpEncodingParameters.ssrc/rtx/fec. r=jib,webidl,smaug

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7c830bff0857