Closed Bug 1863634 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 43006 - view-transition: Fix rendering of inlines with box decorations.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43006 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43006
Details from upstream follow.

Khushal Sagar <khushalsagar@chromium.org> wrote:

view-transition: Fix rendering of inlines with box decorations.

The ink overflow rect computation for inlines misses overflow from box
decorations like box-shadow. Fix that by using
LinesVisualOverflowBoundingBox() which includes this overflow instead of
PhysicalLinesBorderBox() which is limited to border box bounds.

Since LinesVisualOverflowBoundingBox() also includes all overflow from
child text nodes (from text-shadow for example), we can skip iterating
those children as well. This iteration is still needed for text nodes
from non-inline LayoutObjects.

Bug:1496876
Change-Id: I211028f1edc7cb4ba7f5e5e6e89e3d119d3d057c
Reviewed-on: https://chromium-review.googlesource.com/5010350
WPT-Export-Revision: 053e335d3380ba3a996d65d1fe1603d78d28cd81

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

PASS: 2
FAIL: 1

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d84b52aab0fc [wpt PR 43006] - view-transition: Fix rendering of inlines with box decorations., a=testonly https://hg.mozilla.org/integration/autoland/rev/ecd3fce2d011 [wpt PR 43006] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/008722e8f331 [wpt PR 43006] - view-transition: Fix rendering of inlines with box decorations., a=testonly https://hg.mozilla.org/integration/autoland/rev/8f2bc4f24a11 [wpt PR 43006] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/008722e8f331
https://hg.mozilla.org/mozilla-central/rev/8f2bc4f24a11

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.