1863746 - Update text format and internal names for last minute GC changes

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

The GC proposal had a couple last minute changes to instruction names.

i31.new -> ref.i31
extern.internalize -> any.convert_extern
extern.externalize -> extern.convert_any

https://webassembly.github.io/gc/core/text/instructions.html#reference-instructions

We should update wast, our tests, and our internal binary names.

This is not user facing, so not a high priority.

Comment 1

[Julien Pages [:jpages]]

Ben Already updated this one:

i31.new -> ref.i31

See: https://github.com/bytecodealliance/wasm-tools/commit/3fa59ade8a8819e3a9ad39f3f5c6a310b6454bc4

The other two still need to be updated.

Comment 2

[Julien Pages [:jpages]]

Attachment: WIP: Bug 1863746 - wasm: Update crates for wast, wasm-encoder, wasm-smith, wasmparser

Comment 3

[Julien Pages [:jpages]]

Attachment: WIP: Bug 1863746 - wasm: Update tests after changes in wast.

If/then/else parsing was changed in wast. An if must have a
corresponding then, if any, else is mandatory as well.

Depends on D193719

Comment 4

[Julien Pages [:jpages]]

Attachment: Bug 1863746 - wasm: Update crates for wasm-tools. r=rhunt

Comment 5

[Julien Pages [:jpages]]

Attachment: Bug 1863746 - wasm: Update tests after changes in wast. r=rhunt

If/then/else parsing was changed in wast. An if must have a
corresponding then, if any, else is mandatory as well.

Depends on D194157

Comment 6

[Julien Pages [:jpages]]

Attachment: Bug 1863746 - wasm: Rename some wasm-gc instructions. r=rhunt

Due to a last minute change in wasm-gc spec, the following instructions
are renamed:
extern.internalize -> any.convert_extern
extern.externalize -> extern.convert_any

Depends on D194158

Comment 7

[Julien Pages [:jpages]]

Attachment: Bug 1863746 - Update wasmparser to version 5.9.0.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3f2437b7aae
wasm: Update crates for wasm-tools. r=rhunt,supply-chain-reviewers
https://hg.mozilla.org/integration/autoland/rev/651c33ce3a00
wasm: Update tests after changes in wast. r=rhunt,yury
https://hg.mozilla.org/integration/autoland/rev/7725320e9249
wasm: Rename some wasm-gc instructions. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/a62ab1eae5ce
Update wasmparser to version 5.9.0. r=yury,devtools-reviewers

Comment 9

[Cristina Horotan [:chorotan]]

Backed out 4 changesets (bug 1863746) for causing SM failures at binop-arm64-ion-codegen.js

Backout: https://hg.mozilla.org/integration/autoland/rev/b6cf30e25fa29a60a50943a52f8e4310421764d8

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Tltfee4oRtWb7q8vlE0kHw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a62ab1eae5ce1a1dd856c55e0486ad0edb45ad3a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=437183813&repo=autoland&lineNumber=16520

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2824901b25
wasm: Update crates for wasm-tools. r=rhunt,supply-chain-reviewers
https://hg.mozilla.org/integration/autoland/rev/fa924267e288
wasm: Update tests after changes in wast. r=rhunt,yury
https://hg.mozilla.org/integration/autoland/rev/078db2f254d9
wasm: Rename some wasm-gc instructions. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/c451aefee42d
Update wasmparser to version 5.9.0. r=yury,devtools-reviewers

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4c2824901b25
https://hg.mozilla.org/mozilla-central/rev/fa924267e288
https://hg.mozilla.org/mozilla-central/rev/078db2f254d9
https://hg.mozilla.org/mozilla-central/rev/c451aefee42d