1863801 - Infer form submission after DOMDocFetchSuccess event and form removal in FormAutofill

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task)

Description

[Janika Neuberger (:janika)]

We also want to capture addresses that are submitted by a fetch or xhr request instead of a standard form submission event. Usually as a next step after a successful fetch or xhr request, the address form is removed from the DOM.

The two implementation steps are:

• P1. Add a listener for the DOMDocFetchSuccess event when the user focuses in an address field
• P2. Infer form submission when the address form is removed

Comment 1

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P1. Add DOMDocFetchSuccess event listener when the user interacts with address or cc field r=dimi!

Comment 2

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi!

Depends on D193102

Comment 3

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P3. Infer a form submission after DOMFormRemoved event r=dimi!

Depends on D193308

Comment 4

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P5. Add test for address capture for form removal heuristic r=dimi!

Test that we infer a form submission after a successful xhr/fetch request followed by a form removal.
Then the address fields are captured and stored.

Depends on D193633

Comment 5

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P4. Add preference extensions.formautofill.heuristics.captureOnFormRemoval r=dimi!

Depends on D194234

Comment 6

[Janika Neuberger (:janika)]

Attachment: Bug 1863801 - P0. Register the event listener for the DOMDocFetchSuccess by calling addEventListener in LoginManagerChild r=dimi!

In P1 to P4 the FormAutofill starts listening to the DOMDocFetchSuccess event to detect form submissions.
FormAutofill and LoginManager will both use SetNotifyFetchSuccess to initiate the document to fire the event.
The LoginManager now manually adds the event listener, instead of always listening and acting on it.
This prevents interference between the LoginManager and FormAutofill.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31e08bae4ce6
P0. Register the event listener for the DOMDocFetchSuccess by calling addEventListener in LoginManagerChild r=dimi
https://hg.mozilla.org/integration/autoland/rev/5f6ad20da89e
P1. Add DOMDocFetchSuccess event listener when the user interacts with address or cc field r=dimi
https://hg.mozilla.org/integration/autoland/rev/dd78261ec1d8
P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi
https://hg.mozilla.org/integration/autoland/rev/193d5c08a17f
P3. Infer a form submission after DOMFormRemoved event r=dimi
https://hg.mozilla.org/integration/autoland/rev/8d297207efc7
P4. Add preference extensions.formautofill.heuristics.captureOnFormRemoval r=dimi
https://hg.mozilla.org/integration/autoland/rev/c27de56bd433
P5. Add test for address capture for form removal heuristic r=dimi

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 7 changesets (Bug 1863801, Bug 1865876) for causing failures in browser_creditCard_doorhanger_iframe.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=UwAtrWPuTQSvUnyL5ik4yg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=395e2da83ee8013844620d77f01730af2164eafc

Log: https://treeherder.mozilla.org/logviewer?job_id=438520340&repo=autoland&lineNumber=10737

Backout: https://hg.mozilla.org/integration/autoland/rev/68d282cd2e440c68e3ee3b7212b0ec80ff165556

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b0e2e4d652a
P0. Register the event listener for the DOMDocFetchSuccess by calling addEventListener in LoginManagerChild r=dimi
https://hg.mozilla.org/integration/autoland/rev/72f0587fda19
P1. Add DOMDocFetchSuccess event listener when the user interacts with address or cc field r=dimi
https://hg.mozilla.org/integration/autoland/rev/d6e17dcf00a4
P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi
https://hg.mozilla.org/integration/autoland/rev/157fc7d2c5da
P3. Infer a form submission after DOMFormRemoved event r=dimi
https://hg.mozilla.org/integration/autoland/rev/12253bf8fb88
P4. Add preference extensions.formautofill.heuristics.captureOnFormRemoval r=dimi

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4b0e2e4d652a
https://hg.mozilla.org/mozilla-central/rev/72f0587fda19
https://hg.mozilla.org/mozilla-central/rev/d6e17dcf00a4
https://hg.mozilla.org/mozilla-central/rev/157fc7d2c5da
https://hg.mozilla.org/mozilla-central/rev/12253bf8fb88

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9004e2d6ae97
P5. Add test for address capture for form removal heuristic r=dimi

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9004e2d6ae97