Open Bug 1864100 Opened 2 years ago Updated 2 years ago

"Filter platforms & jobs" field doesn't match with copied job name

Categories

(Tree Management :: Treeherder: Frontend, enhancement)

enhancement

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

Steps to reproduce:

  1. click M(bc13) job https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=MgjoU1LiTV2cdvXppjcR2g.0&revision=a9f50569adb2db2a6294973a2e54d837034432a1
  2. click copy button for "Job name". this copies "test-linux1804-64-qr/debug-mochitest-browser-chrome-13" text
  3. unselect the job by clicking empty area
  4. put the copied text "test-linux1804-64-qr/debug-mochitest-browser-chrome-13" into "Filter platforms & jobs" field and hit enter

Actual result:
no jobs are shown

Expected result:
M(bc13) job is shown

This comes from the "searchStr" doesn't contain the exact job name with chunk number.
M(bc13)'s "searchStr" is "Linux 18.04 x64 WebRender debug Mochitests test-linux1804-64-qr/debug-mochitest-browser-chrome bc13".
"test-linux1804-64-qr/debug-mochitest-browser-chrome" is included, but it doesn't have the chunk number.

The chunk number is explicitly removed in this part

https://github.com/mozilla/treeherder/blob/be248849ee6483102c5eb63d673a418a24df7ee1/ui/helpers/job.js#L187-L201

  // The current modification is to support backfilling of manifest based scheduling.
  // A backfilled task (e.g. bc2) ends up being named bc2-<revision>-bk
  // The label can also be different than the original task selected to be backfilled
  // For instance 'test-linux1804-64/debug-mochitest-browser-chrome-e10s-4' can be
  // 'test-linux1804-64/debug-mochitest-browser-chrome-e10s-1' yet the symbol be bc4
  const parts = jobTypeName.split('-');
  // This makes backfilled tasks have the same symbol as the original task
  if (jobTypeSymbol.endsWith('-bk')) {
    [jobTypeSymbol] = jobTypeSymbol.split('-');
  }
  const chunk = Number(parts.pop());
  if (Number.isInteger(chunk)) {
    jobTypeName = parts.join('-');
    jobTypeSymbol = jobTypeSymbol.split('-').shift();
  }

can we add both original jobTypeName and modified jobTypeName ?

Attached file GitHub Pull Request
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: