1864126 - The clipboard icon is not displayed in HCM for macOS

Status: NEW

(Firefox :: Address Bar, defect, P2)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: HCM Win11.png

Found in

• 121.0a1 (20231109165012)

Affected versions

• 121.0a1 (20231109165012)

Tested platforms

• Affected platforms: macOS 14, macOS 13
• Unaffected platforms: Windows 11, Ubuntu 22

Preconditions

• Set browser.urlbar.clipboard.featureGate to true.
• Set the OS to HC mode ( Accessibility -> Display -> Invert Colors + Increase Contrast)

Steps to reproduce

1. Launch Firefox.
2. Copy an URL link from NTP.
3. Click on the URL bar.

Expected result

• The Clipboard icon is displayed without any issues in HCM)

Actual result

• The clipboard icon is not displayed in HCM.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:vlucaci, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Josh Berman]

Hey there,

Valid bug. Please see the figma file for Visit from Clipboard for the correct HCM specs. According to these specs, the icon should have a ButtonText property in the URL item row's default state.

https://www.figma.com/file/yRxVvzTnrdBdcS09kMmpi0/Paste-from-clipboard?type=design&node-id=87%3A8319&mode=dev

Comment 3

[Emilio Cobos Álvarez [:emilio]]

This is a more general issue when using inverted colors, see https://github.com/w3c/csswg-drafts/issues/9674. It's more visible in hcm, but not 100% related to it.

As a workaround, when using these svgs we could also specifiy filter: none or so.

Comment 4

[Marco Bonardo [:mak]]

I expect filter: none to not solve the problem completely, as we cannot distinguish the default icon being shown when for example a favicon is missing. We could apply it only to specific cases where we hardcode an icon.
I think it may be worth awaiting for the spec issue to be solved before re-evaluating what needs to be done here for the icons.

We could check, excluding favicons, what other parts of the spec don't match, and address those apart.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Right, the point would be to use filter: none wherever we use content: url(<stuff>.svg) (and wherever it's not overridden of course). Not trivial, and yeah probably not worth the whackamole until the spec issue is sorted out