1864149 - TypeError: can't access property "handleSMimeMessage" when selecting message with invalid S/MIME signature. This also stalls gloda indexing.

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect, P1)

Description

[Hartmut Welpmann [:welpy-cw]]

When gloda didn't seem to be able to finish indexing a folder, I noticed the following error message in the console:

TypeError: can't access property "handleSMimeMessage", mimeSvc.mailChannel.smimeHeaderSink is null        pgpmimeHandler.jsm:242:5
    handleSmime chrome://openpgp/content/modules/pgpmimeHandler.jsm:242
    onStartRequest chrome://openpgp/content/modules/pgpmimeHandler.jsm:195

Apparently a message with an invalid signature is the cause, just selecting it throws the same error. Excerpts from this message:

Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; 
	boundary="----=_Part_3096197_2000219346.1400078607082"

------=_Part_3096197_2000219346.1400078607082
Content-Type: application/pkcs7-signature; name=smime.p7s; smime-type=signed-data
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1864149 - Prevent TypeError when handling S/MIME messages. r=kaie

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Digital Signature Is Not Valid

Comment 3

[Kai Engert [:KaiE:]]

Could you please forward me a message for which you see this happen?
(Please use file, save as, which gives you an .eml file, then zip it and please send the zip to me by email.)

Could you please update the patch?
The file you changed was moved to a different filename:
mail/extensions/openpgp/PgpMimeHandler.sys.mjs

Comment 4

[Kai Engert [:KaiE:]]

(renamed in bug 1865550)

Comment 5

[Wayne Mery (:wsmwk)]

I suggest this is a high priority, because it breaks indexing.

I feel like this must be a regression, no? I ask partly because finding messages is a key part of my work and I'd like to go back to the version which didn't have the bug.

Also noteworthy, mine is currently stuck indexing Sent, but finding the message will be difficult because with bug 1823024 I don't know which account.

Comment 6

[Wayne Mery (:wsmwk)]

Using nightly builds and https://mozilla.github.io/mozregression/ the regression range can be found.

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Regressed by bug 1852922, I think all betas since 119.0b1 are affected.

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Maybe we can fast-track adding that missing question mark to have this fixed in 122.0b1.

Comment 9

[Kai Engert [:KaiE:]]

I accepted the patch.
I had not noticed that you had updated it, sorry for the delay.

Comment 10

[Wayne Mery (:wsmwk)]

This will be fixed on beta by the merge on Monday.

Comment 11

[Kai Engert [:KaiE:]]

Hartmut sent me an example message.

I don't get the exception with that message.

I still cannot reproduce the bug.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/111f9aee5848
Prevent TypeError when handling S/MIME messages. r=kaie

Comment 13

[Hartmut Welpmann [:welpy-cw]]

(In reply to Kai Engert (:KaiE:) from comment #11)

I don't get the exception with that message.

When I open that .eml file and copy the message into an empty local folder, error console shows

console.error: gloda.datastore: "got error in _asyncTrackerListener.handleError(): 19: constraint failed"

After restarting or switching indexing off and on in the folder's properties I get

JavaScript error: resource:///modules/PgpMimeHandler.sys.mjs, line 224: TypeError: can't access property "handleSMimeMessage", mimeSvc.mailChannel.smimeHeaderSink is null
The MsgHdrToMimeMessage callback threw an exception: TypeError: can't access property "parts", aPart is null
JavaScript error: resource:///modules/gloda/MimeMessage.jsm, line 153: TypeError: can't access property "parts", aPart is null

Comment 15

[Kai Engert [:KaiE:]]

Ok, with a fresh profile, and having the message already in an IMAP folder, I can reproduce the error that you're patching.

I don't get the other errors from comment 13.