1864212 - Reduce the amount of code that we generate for logical properties.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1864212 - Reduce the amount of code that we generate for logical properties. r=#style,#layout

This performs a couple of related changes I've wanted to do for a while.

Right now, we generate a lot of redundant code for logical properties,
when the cascade is already taking care of physicalizing them.

Also, LonghandId::to_physical is doing a lot more work than it should
(for actual logical properties). Instead, use a table-lookup-based
implementation which should be faster and generate less code.

For that, we need to perform a couple changes to the logical_geometry
code, including some conversions that I borrowed from WritingMode.h.

But other than that it should be mostly straight-forward: We already
assert that all properties in the same logical group have the same
specified value type.

Also this gets rid of the logical-getter-helper shenanigans, which was
very hard to reason about.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=430f233c207f643b89b3f939f4fe5e98c49ffc7a&newProject=try&newRevision=dfaf5f29d3c6dcf940e730c6c9945b15138218d9

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c22a3344faf4
Reduce the amount of code that we generate for logical properties. r=jwatt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239b5d197b0f
Re-introduce some changes that were lost during rebase.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c22a3344faf4
https://hg.mozilla.org/mozilla-central/rev/239b5d197b0f