1864258 - [css-color] HSL & HWB syntax should allow numbers as well as percentage.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Tiaan Louw]

According to:
https://drafts.csswg.org/css-color-4/#the-hwb-notation

the HWB syntax allows percentages and numbers for the whiteness and blackness components:

hwb() = hwb( 
  [<hue> | none] 
  [<percentage> | <number> | none] 
  [<percentage> | <number> | none] 
  [ / [<alpha-value> | none] ]? )

Currently we only parse percentages for those components.

hwb(20deg 50 40) should be a valid hwb value. The color-valid-hwb.html wpt test doesn't test for these values either.

According to:
https://drafts.csswg.org/css-color-4/#the-hsl-notation

the modern HSL syntax allows percentages and numbers for the saturation and lightness components:

<modern-hsl-syntax> = hsl( 
    [<hue> | none] 
    [<percentage> | <number> | none] 
    [<percentage> | <number> | none] 
    [ / [<alpha-value> | none] ]? )

Currently we only parse percentages for the modern syntax.

hsl(20deg 50 40) should be a valid hsl value. The color-valid-hsl.html wpt test doesn't test for these values either.

Comment 1

[Tiaan Louw]

Attachment: Bug 1864258 - HSL and HWB syntax should allow numbers as well as percentage r=#layout

https://drafts.csswg.org/css-color-4/#the-hwb-notation

Comment 2

[Tiaan Louw]

Attachment: Bug 1864258 - Change HSL and HWB to store components as numbers r=emilio,#layout

The second and third components for HSL and HWB are stored as
percentages in the range [0..1], but as part of the change to allow
numbers for those two components as well as percentages, they act like
all the other <number-or-percentage> components. This means the values
are store in their number value. For HSL and HWB they both match with
the percentage values and are in the range [0..100].

https://drafts.csswg.org/css-color-4/#the-hsl-notation
https://drafts.csswg.org/css-color-4/#the-hwb-notation

Change to the accepted types for the components are discussed here:
https://github.com/w3c/csswg-drafts/issues/8322

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23dfad39643a
Change HSL and HWB to store components as numbers r=emilio,layout-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf1b9592b97f
HSL and HWB syntax should allow numbers as well as percentage r=layout-reviewers,emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43320 for changes under testing/web-platform/tests

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/23dfad39643a

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cf1b9592b97f

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot