1864287 - Use punycode in SeaMonkey JS

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, task)

Description

[Ian Neal]

Port the JS changes from bug 1380617

Comment 1

[Ian Neal]

Attachment: 1864287-punycode-25319.patch

[Approval Request Comment]
Regression caused by (bug #): 1380617
User impact if declined: some stuff not displayed correctly?
Testing completed (on m-c, etc.): 2.53.19
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9363126 [details] [diff] [review]
1864287-punycode-25319.patch

looks good and I didn't notice any regressions during testing. r/a+

One thing I am not a big fan of are assignments like these:

 docInfo.location = document.location.toString();

• try {

•  docInfo.location = Services.io.newURI(document.location.toString()).displaySpec;
  

• } catch (exception) { }

Performanc ewise they should be made in the exception to make sure the variable is intialized only once. Shouldn't matter but I find it also a bit "undefined behaviour territory" when the exception occurs late in the assignment. With js the original variable is probably kept untouched or we would have seen more problems because if it. But something to discuss for a later day.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9363126 [details] [diff] [review]
1864287-punycode-25319.patch

upps

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/cfd70cf53a8d5932b925d8f271d32a48f44b56bb
Use punycode in SeaMonkey JS. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/978d50e85bf0cdd7f24de156f618752bc9ec0ac4
Use punycode in SeaMonkey JS. r=frg a=frg