1864478 - [HCM] The new Search icon is not visible in PBM when a high contrast black theme is enabled on Windows

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: Comparison with the Search icon on the black theme vs white theme

Found in

• Nightly 121.0a1

Affected versions

• Firefox 120 beta
• Nightly 121.0a1

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: Ubuntu 22.04, macOS 11.7

Preconditions

• In about:config, set "browser.privatebrowsing.felt-privacy-v1" to true
• Enable High Contrast Mode - set the High Contrast Black Theme.

Steps to reproduce

1. Open a private window.
2. Observe the in-content Search field.

Expected result

• A generic search icon should be displayed on the left side of the "Search with Google or enter address" text.

Actual result

• On Windows 10 with a black theme selected, the generic search icon is not visible.

Regression range

• Not a regression.

Additional notes

• The old search icon is visible with a high contrast black theme when the pref "browser.privatebrowsing.felt-privacy-v1" is set to false.
• This issue is not reproducible on macOS X or Ubuntu when high contrast + black themes are enabled.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Anna Yeddi [:ayeddi]]

Since the icon is fully missing, this removes any on-screen label for users, thus creating access-s2 issue.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:cmkm, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847102

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Hi Cieara, we're about halfway through the Beta cycle for 121 and it goes to RC the week after next. Is this on track for having an upliftable fix before then?

Comment 6

[:cmkm]

This should have a patch this week and should be on track for beta uplift.

Comment 7

[:cmkm]

Attachment: Bug 1864478 - PBM search in Felt Privacy HCM updates r?mhowell

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daef3ff209d0
PBM search in Felt Privacy HCM updates r=desktop-theme-reviewers,mhowell,dao

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/daef3ff209d0

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:cmkm, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[:cmkm]

Comment on attachment 9366376 [details]
Bug 1864478 - PBM search in Felt Privacy HCM updates r?mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Windows HCM users enrolled in the Felt Privacy experiment will have a poorer experience as a search indicator is missing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment #0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects styling in Felt Privacy experiment
• String changes made/needed: n/a
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366376 [details]
Bug 1864478 - PBM search in Felt Privacy HCM updates r?mhowell

Approved for 121.0b9.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cf586351d603

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 122.0a1 (Build ID: 20231207165826) on Windows 10 x64 - the search icon is now visible in Private Browsing while HCM is enabled.

Comment 15

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 121.0b9 (Build ID: 20231208091859) on Windows 10 x64 - the search icon is properly displayed in Private Browsing while HCM is enabled.