Open Bug 1864526 Opened 8 months ago Updated 7 months ago

Authenticator-rs keeps device monitor thread alive after a transaction is completed

Categories

(Core :: DOM: Web Authentication, defect, P3)

defect

Tracking

()

People

(Reporter: jschanck, Assigned: jschanck)

References

Details

In Bug 1844136 we stopped using the authenticator-rs Manager type, but we didn't replicate all of its behavior. In particular, the Drop implementation on Manager cancels the Transaction that is owned by the Manager's StateMachine. Surprisingly, dropping a Manager was the only way to stop the device monitor thread (assuming the transaction was not cancelled by the user at a browser prompt).

See Also: → 1863135

fwiw, i have reports from users on OpenBSD that this prevents other programs from accessing the fido device (cf https://marc.info/?l=openbsd-tech&m=170206115205111&w=2), and wonder if it's related to that issue or to something else (eg not enough code in the openbsd-specific parts of authenticator-rs). They've reported me that the issue is still present in 121.0b9, which includes the commit from bug #1863135

Thanks, I reopened Bug 1863135 and attached another patch.

You need to log in before you can comment on or make changes to this bug.