1864648 - [wpt-sync] Sync PR 43151 - Once content is added to a builder, break as normally.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43151 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43151
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Once content is added to a builder, break as normally.

If the RequiresContentBeforeBreaking flag was set when initializing the
fragment builder, it was never set to false again. This was generally
unproblematic, since it only affected last-resort break opportunities,
which generally only occur at the beginning of a fragment (e.g. between
a container and its first child). However, in flex layout there may be a
last-resort break opportunity before any flex item that's flush with its
flex line, because that is seen as having no container separation.

Therefore, reset the RequiresContentBeforeBreaking flag once a child has
been added to the builder. That in itself is a simple fix, in
NGBoxFragmentBuilder::AddChild().

The rest of this CL is about keeping this mechanism working for
out-of-flow positioned elements. We now need to check the
RequiresContentBeforeBreaking state exactly when the out-of-flow
positioned element is found in the box tree, not when it's being laid
out. Doing it later, in NGOutOfFlowLayoutPart, is now too late, since
the flag may have been reset in the meantime, which would prevent us
from forcing OOFs to stay in the current fragmentainer when they should.
So store it directly in NGLogicalOutOfFlowPositionedNode when creating
it. Since these objects bubble up the parent chain as physical
fragments, NGPhysicalOutOfFlowPositionedNode also needs to store this.
Storing it in NGContainingBlock is no longer necessary, on the other
hand.

css/css-break/tall-content-inside-constrained-block-006.tentative.html
is a test for this.

Bug: 1500947
Change-Id: I3b60239b0bdac82477748b3e0a99daf074d7246d
Reviewed-on: https://chromium-review.googlesource.com/5029777
WPT-Export-Revision: 27a1c7008e47254fc16d1e19e29510d067d2b66f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=21a545ae9c4069b5b2dd0e3c9ceff143c585783c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

FAIL: 3

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8872dc769f0
[wpt PR 43151] - Once content is added to a builder, break as normally., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8bef5d2717f
[wpt PR 43151] - Once content is added to a builder, break as normally., a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d8bef5d2717f