Closed Bug 1864760 Opened 11 months ago Closed 8 months ago

Remove all button actions from Toolbar in BrowserFragment

Categories

(Fenix :: Toolbar, task)

All
Android
task

Tracking

(firefox124 fixed, firefox125 fixed)

RESOLVED FIXED
125 Branch
Tracking Status
firefox124 --- fixed
firefox125 --- fixed

People

(Reporter: harrisono, Assigned: harrisono)

References

Details

(Whiteboard: [fxdroid])

Attachments

(2 files)

No description provided.

I'd like to voice a few design points before any potential permanent hiding of the tab counter in portrait mode. (As a disclaimer, the new design doc is not available to me.)

  • Current tab button placement is functional and convenient for one-handed operation.
  • The tab button is not solely for listing open tabs. It also provides a long-press shortcut for closing the current tab.
  • With or without the tab button, mobile toolbar is never going to have enough real estate to show a complete URL; therefore, permanently hiding tab button without a way of turning it back on makes little sense.
  • Please provide a setting to always turn it back on if removed by default.
  • In general, as with any potential feature change based on any kind of statistical/telemetry feedback, power users' used cases cannot be discounted. While the share of those users may look small, those users are Firefox champions who pull general users behind them.
Assignee: nobody → hoglesby
Status: NEW → ASSIGNED
Whiteboard: [fxdroid]
Summary: Show/hide the tab counter and menu depending on screen size → Show/hide the tab counter and menu with secret setting
Summary: Show/hide the tab counter and menu with secret setting → Remove all button actions from toolbar in browser fragment
Summary: Remove all button actions from toolbar in browser fragment → Remove all button actions from Toolbar in BrowserFragment
Duplicate of this bug: 1868902
Attachment #9367510 - Attachment description: [mozilla-mobile/firefox-android] Bug 1864760 - Hide tab counter button in portrait mode (#4753) → [mozilla-mobile/firefox-android] Bug 1864760 - Hide toolbar actions in BrowserFragment (#4753)

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/904518801d8dbbdd871a2c05fb1212887f8c7af4
[main] Bug 1864760 - Added actions to Toolbar and MenuButton to hide and show the menu button

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/b0497a2b730cffe415a3ab11552e8dab7bde15cb
[main] Bug 1864760 - Hide Menu, Home, and Tab counter button from BrowserFragment Toolbar.

Target Milestone: 124 Branch → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: