1864851 - [css-color] Hue longer interpolation method is incorrect when angles are equal

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Tiaan Louw]

For example:

color-mix(in hsl longer hue, hsl(0, 100%, 50%), hue(0, 100%, 50%))

will result in:

hsl(0, 100%, 50%)

but should interpolate the hue around the longer side which is:

hsl(180, 100%, 50%)

There is a small discrepancy in the code here:
https://searchfox.org/mozilla-central/rev/7e60ac48dc5b3e3f06c1baf2a9a6e0352bd85c01/servo/components/style/color/mix.rs#407

The second if statement should be: delta <= 0. and not delta < 0

as per: https://drafts.csswg.org/css-color-4/#hue-longer

Comment 1

[Tiaan Louw]

Attachment: Bug 1864851 - Fix the hue longer interpolation method. r=#layout

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61082f7c029f
Fix the hue longer interpolation method. r=layout-reviewers,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43187 for changes under testing/web-platform/tests

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/61082f7c029f

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/61082f7c029f

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot