1864896 - Turn on argument linting from no-unused-vars

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[:Gijs (he/him)]

no-unused-vars currently ignores unused function arguments.

Running this in browser/components/ (as a sample) finds about 220 issues.

A large portion of these seem to be cases where the method signature is defined elsewhere (e.g. handleEvent(event), observe(subject, topic, data)). It would be nice if we could ignore those, but it looks like eslint does not have a direct facility for this. You can specify patterns of variables to ignore but of course ignoring all arguments called data would probably not be great.

One option would be to switch code to use _ prefixes for unused arguments to make it explicit, and that could be a solution for these cases. This is an example given in the eslint docs with the argsIgnorePattern: /^_/ option, so is presumably a wider convention.

Thoughts on doing this?

Comment 1

[Mark Banner (:standard8)]

I see around 800 issues, but I'm probably configuring it in a different place.

As you indicate there are two groups - the listener/observer/callback style of functions whose interfaces are defined elsewhere, and the functions which are being defined.

For the listener cases, I do find that it is often useful to have the arguments there, as they help remind me what the options are, especially when potentially extending a function. In those cases having _ would be a little annoying as it makes it harder to know what the item being skipped actually is. We could possibly use argsIgnorePattern: /^_.+/ as the option instead to enforce more than just _.

For the case where the code is defining the function, I think it is definitely useful - VS Code highlights this, but not everyone uses VS Code, nor will they necessarily spot it. There's definitely some places in our code where we have unused parameters that look wrong, and as a result we're unnecessarily passing extra items to those functions. These cases weren't always at the end of the arguments, some were at the start as well.

I think it could be quite a bit of work to enable, but I do think it would be worth it to help ensure code is tidied, especially when refactoring. To aid the roll-out we could potentially enable on non-test code first, and then think about test code later. From what I've seen, it would probably be worth enabling it on both eventually.

Comment 2

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #1)

I see around 800 issues, but I'm probably configuring it in a different place.

As you indicate there are two groups - the listener/observer/callback style of functions whose interfaces are defined elsewhere, and the functions which are being defined.

For the listener cases, I do find that it is often useful to have the arguments there, as they help remind me what the options are, especially when potentially extending a function. In those cases having _ would be a little annoying as it makes it harder to know what the item being skipped actually is. We could possibly use argsIgnorePattern: /^_.+/ as the option instead to enforce more than just _.

Yes, sorry, I did mean that we'd use _data or _event rather than just _.

Comment 3

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #0)

A large portion of these seem to be cases where the method signature is defined elsewhere (e.g. handleEvent(event), observe(subject, topic, data)). It would be nice if we could ignore those, but it looks like eslint does not have a direct facility for this. You can specify patterns of variables to ignore but of course ignoring all arguments called data would probably not be great.

But if the arguments aren't used in the function then not including them in the function signature is fine. Why would we want to leave them in?

Comment 4

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] from comment #3)

(In reply to :Gijs (he/him) from comment #0)

A large portion of these seem to be cases where the method signature is defined elsewhere (e.g. handleEvent(event), observe(subject, topic, data)). It would be nice if we could ignore those, but it looks like eslint does not have a direct facility for this. You can specify patterns of variables to ignore but of course ignoring all arguments called data would probably not be great.

But if the arguments aren't used in the function then not including them in the function signature is fine. Why would we want to leave them in?

I think it helps make it clearer that it's an nsIObserver / event listener thingy, as opposed to a random function that has no args (esp. when the function has no name - nsIObserver has the idl function annotation so you can pass (subject, topic, data) => doStuff() to addObserver), and makes it obvious that input is available that could be used to help guide decisions inside the function, as well as reducing churn both for enabling the rule and when whether or not you use the arg changes (though that's moot if we go the prefix route as you'd still need to touch the line). But it's a fair point, we could also "just" strip everything that's unused, I guess - do you feel strongly we should?

Comment 5

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #4)

(In reply to Dave Townsend [:mossop] from comment #3)

(In reply to :Gijs (he/him) from comment #0)

A large portion of these seem to be cases where the method signature is defined elsewhere (e.g. handleEvent(event), observe(subject, topic, data)). It would be nice if we could ignore those, but it looks like eslint does not have a direct facility for this. You can specify patterns of variables to ignore but of course ignoring all arguments called data would probably not be great.

But if the arguments aren't used in the function then not including them in the function signature is fine. Why would we want to leave them in?

I think it helps make it clearer that it's an nsIObserver / event listener thingy, as opposed to a random function that has no args (esp. when the function has no name - nsIObserver has the idl function annotation so you can pass (subject, topic, data) => doStuff() to addObserver), and makes it obvious that input is available that could be used to help guide decisions inside the function, as well as reducing churn both for enabling the rule and when whether or not you use the arg changes (though that's moot if we go the prefix route as you'd still need to touch the line). But it's a fair point, we could also "just" strip everything that's unused, I guess - do you feel strongly we should?

Honestly not too sure. If we think it is useful to mark observer functions using the arguments does that hold for other callback-like functions, should anything passed to Array.map be (item, index, arr) => {}? I think not but I can't say why that's different.

Comment 6

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] from comment #5)

Honestly not too sure. If we think it is useful to mark observer functions using the arguments does that hold for other callback-like functions, should anything passed to Array.map be (item, index, arr) => {}? I think not but I can't say why that's different.

I guess I'd think that for 99% of map functions I've ever written, a reference to the array or index are not useful. For observe(), I'd hazard a guess that in more than half of all cases outside of tests I'd want at least the topic, and often (maybe 10-30% of cases?) the subject and/or data as well.

But the flip side of my argument is that if someone were to write observe() {} or handleEvent() {}, the linter can't fault them for not listing the arguments that are technically still provided to the function. So wanting to list the args for education/"contract" purposes is only enforceable by convention / humans, which is bad. To change that we'd need typescript or something...

So even though, from a manual review PoV I'd never really comment on people having an unused event or subject/topic/data param for these functions, so the argument there would be to avoid touching code / making it harder to start using those args. But we can't really avoid touching that code while enabling the rule unless we add eslint-disable-next-line comments which is horrible so I don't want to do that. There's also no way to ignore arguments based on the name of the function rather than the argument.

So I think maybe we should just accept that these are gonna get clobbered by the linter if not used? There are probably already (many?) instances of observe() that don't list the last data arg (esp. when passing just an arrow function). Admittedly, there are only 3 cases of handleEvent without an arg in the entire tree... https://searchfox.org/mozilla-central/search?q=handleEvent%28%29+%7B&path=&case=true&regexp=false but perhaps that speaks more to using the event? I haven't checked how many of the with-arg instances would be removed by the linter.

Sorry, lots of waffling to say that maybe I'm changing my mind and we should just go ahead and clobber all of this stuff. Perhaps it's shaped by just digging into some blame/annotate stuff and having to jump past a few eslint revisions. Comparatively, touching these lines isn't going to be the end of the world...

Comment 7

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #6)

(In reply to Dave Townsend [:mossop] from comment #5)

Honestly not too sure. If we think it is useful to mark observer functions using the arguments does that hold for other callback-like functions, should anything passed to Array.map be (item, index, arr) => {}? I think not but I can't say why that's different.

I guess I'd think that for 99% of map functions I've ever written, a reference to the array or index are not useful. For observe(), I'd hazard a guess that in more than half of all cases outside of tests I'd want at least the topic, and often (maybe 10-30% of cases?) the subject and/or data as well.

Right. But I think those arguments are either useful or not and you know to add them when you're writing the function. I think it's rare that you realise later that you do actually need the data argument to an observe function. Maybe the main case being where you start observing a new topic for the same function at which point you know the function is an observer callback anyway.

But the flip side of my argument is that if someone were to write observe() {} or handleEvent() {}, the linter can't fault them for not listing the arguments that are technically still provided to the function. So wanting to list the args for education/"contract" purposes is only enforceable by convention / humans, which is bad. To change that we'd need typescript or something...

It's probably possible with a custom eslint rule, but it's work. And if we're only relying on function name I would expect most folks to recognise handleEvent and observe as standard functions and be able to find relatively easily what arguments they can take.

Sorry, lots of waffling to say that maybe I'm changing my mind and we should just go ahead and clobber all of this stuff. Perhaps it's shaped by just digging into some blame/annotate stuff and having to jump past a few eslint revisions. Comparatively, touching these lines isn't going to be the end of the world...

Ok now for the spanner in the works. I just attempt to turn this on, eslint gave me over 7,000 errors (that does include test files though), and the rule isn't automatically fixable so we'd have to correct everything by hand. I'm inclined to say that that isn't worth it.

Comment 8

[Dave Townsend [:mossop]]

Attachment: WIP: Bug 1864896: Add a rule checking for unused function arguments

Comment 9

[Dave Townsend [:mossop]]

Attachment: WIP: Bug 1864896: Autofix trailing arguments in browser/components

Depends on D194400

Comment 10

[Dave Townsend [:mossop]]

Attachment: WIP: Bug 1864896: Add a rule checking for unused function arguments

Comment 11

[Dave Townsend [:mossop]]

The WIP rule can now fix the entire tree and leaves the following errors:

• jsdoc/check-param-names, descriptions of arguments that have been removed (114 instances).
• mozilla/no-unused-args, arguments that cannot be removed automatically because while they are never read from they are written to (20 instances).
• no-empty-pattern, some array destructurs are pointless but we can't remove them from the function arguments automatically (3 instances).

It fixes some 4311 occurrences.

So enough to say that this seems viable to do. So we should figure out if we want to do this for sure and what the plan should be. I'd suggest something like this:

1. Announce on the mailing lists a plan to do this.
2. Create patches for various parts of the tree to split up the review workload.
3. Land.

After that we may be better off sticking with the eslint provided rule for checking this rather than the new version that supports autofixing. I found it to be a problem during development since I have my editor set to fix all lint issues automatically whenever I save, and if you save half-way through writing a new function it will strip the arguments for you.

Comment 12

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] from comment #11)

The WIP rule can now fix the entire tree and leaves the following errors:

• jsdoc/check-param-names, descriptions of arguments that have been removed (114 instances).

Follow-up bug and add eslint ignore comments for now? Then we can burn this down and potentially update callers that pass these now-unneeded arguments...

• mozilla/no-unused-args, arguments that cannot be removed automatically because while they are never read from they are written to (20 instances).

I imagine this needs manual fixing?

• no-empty-pattern, some array destructurs are pointless but we can't remove them from the function arguments automatically (3 instances).

It fixes some 4311 occurrences.

So enough to say that this seems viable to do. So we should figure out if we want to do this for sure and what the plan should be. I'd suggest something like this:

1. Announce on the mailing lists a plan to do this.
2. Create patches for various parts of the tree to split up the review workload.
3. Land.

After that we may be better off sticking with the eslint provided rule for checking this rather than the new version that supports autofixing. I found it to be a problem during development since I have my editor set to fix all lint issues automatically whenever I save, and if you save half-way through writing a new function it will strip the arguments for you.

Agreed on all counts. I think we should additionally split the test-only changes into their own patch(es) because they're lower-impact/risk, but other than that this all sounds good to me.

Comment 13

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #12)

(In reply to Dave Townsend [:mossop] from comment #11)

The WIP rule can now fix the entire tree and leaves the following errors:

• jsdoc/check-param-names, descriptions of arguments that have been removed (114 instances).

Follow-up bug and add eslint ignore comments for now? Then we can burn this down and potentially update callers that pass these now-unneeded arguments...

It might just be as easy to remove those doc comments, they aren't doing anything at that point.

• mozilla/no-unused-args, arguments that cannot be removed automatically because while they are never read from they are written to (20 instances).

I imagine this needs manual fixing?

Yes, some investigation too. The one case I looked at was in a test and made me wonder if the test was faulty.

Comment 14

[Mark Banner (:standard8)]

I'm fine with the plan here - I think it'll help clean up unused params and simplify the callers.

(In reply to Dave Townsend [:mossop] from comment #11)

1. Announce on the mailing lists a plan to do this.
2. Create patches for various parts of the tree to split up the review workload.
3. Land.

After that we may be better off sticking with the eslint provided rule for checking this rather than the new version that supports autofixing. I found it to be a problem during development since I have my editor set to fix all lint issues automatically whenever I save, and if you save half-way through writing a new function it will strip the arguments for you.

I think we should switch to the ESLint one eventually if we're able to (better for maintenance), whilst autofix for this is useful for tree-wide operations, I do wonder about it getting in the way.

One thing I did wonder about is would it work to make mozilla/no-unused-args use suggestions? According to the command line docs, you can get ESLint to auto fix only suggestions. What I don't know is how VS Code and others surface suggestions, I'd have assumed they wouldn't auto-fix, but do you still get the UI to accept the suggestion?

Comment 15

[Dave Townsend [:mossop]]

(In reply to Mark Banner (:standard8) from comment #14)

One thing I did wonder about is would it work to make mozilla/no-unused-args use suggestions? According to the command line docs, you can get ESLint to auto fix only suggestions. What I don't know is how VS Code and others surface suggestions, I'd have assumed they wouldn't auto-fix, but do you still get the UI to accept the suggestion?

That's a good call. In VS Code, at least how I have it configured which I assume is fairly normal, you do still see the error and get UI to accept the fix but it doesn't auto-fix on save anymore. Worth noting that you also get a similar suggestion to fix from VS Code's built-in TypeScript functionality.

Comment 16

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove some unused function arguments from a DOM test. r=#dom-core!

Comment 17

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove some unused arguments from webextension APIs. r=zombie!

Depends on D195630

Comment 18

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Enable unused argument lint rule. r=Standard8!

Depends on D195631

Comment 19

[Tomislav Jovanovic :zombie]

I see this is also considering autofixing class methods, which I don't think is a pure win. Even without typescript[1], it is considered good practice to define methods in base classes that don't do anything (and document their arguments with JSDoc) that can (or need) to be overridden in a subclass. Removing such arguments would result in invalid JSDoc comments.

[1] With typescript, this is actually a requirement, as the overriding function needs to have a signature that's compatible with the base one:

class A {
  /** override to customize Foo */
  do() {}
}

class B extends A {
  /** @param {string} foo */
  do(foo) {
    console.log("B", foo);
  }
}

This is a type-checking error (in JSDoc-hinted and) typescript-checked javascript. Btw, I have a patch up for progressively adding type-checks to /toolkit/components/extensions code in bug 1869678, and I'm fairly confident TypeScript is a better tool for trying to address the root problem here.

Comment 20

[Dave Townsend [:mossop]]

(In reply to Tomislav Jovanovic :zombie from comment #19)

I see this is also considering autofixing class methods, which I don't think is a pure win. Even without typescript[1], it is considered good practice to define methods in base classes that don't do anything (and document their arguments with JSDoc) that can (or need) to be overridden in a subclass. Removing such arguments would result in invalid JSDoc comments.

The number of places we actually use base classes is fairly small right now and until we have something better this isn't a distinction we can reliably make so we either have to somehow turn off this rule for class methods, which isn't possible in the eslint provided rule and doesn't account for only the overrides case, or accept this. It was brought up in the mailing list discussion but it was agreed to go ahead as-is.

Can you elaborate on why JSDoc comments would be invalid?

I'm fairly confident TypeScript is a better tool for trying to address the root problem here.

Sure, but we're a long ways off being able to use TypeScript across the codebase.

Comment 21

[Tomislav Jovanovic :zombie]

The number of places we actually use base classes is fairly small right now

Some of these are WebIDL-based parent classes, but I don't think this is small:
https://searchfox.org/mozilla-central/search?q=class.%2Bextends&path=*.*js&regexp=true

Can you elaborate on why JSDoc comments would be invalid?

class A {
  /** @param {string} foo */
  do(foo) {}
}

This would be the source of the base class before removal of foo. After removal, the JSDoc referencing a non-existing argument is invalid.

Sure, but we're a long ways off being able to use TypeScript across the codebase.

It looks more feasible to me than a few weeks ago, now that I have PoC in bug 1869678. Besides what's already there, I also have our [ChromeOnly] WebIDL definitions converted to a typescript lib-dom.d.ts locally (using a slightly patched TypeScript-DOM-lib-generator). I'll write up a case study/proposal after the holiday break if things work out as expected.

Comment 22

[Magnus Melin [:mkmelin]]

Removing unused arguments could be a bit annoying during development, when it's a WIP patch and you just haven't had the time to utilize the argument yet.

Comment 23

[Mark Banner (:standard8)]

(In reply to Magnus Melin [:mkmelin] from comment #22)

Removing unused arguments could be a bit annoying during development, when it's a WIP patch and you just haven't had the time to utilize the argument yet.

The rule is not automatically fixed. You'll get a error like you do with other items, but it won't get removed.

Comment 24

[Dave Townsend [:mossop]]

(In reply to Tomislav Jovanovic :zombie from comment #21)

The number of places we actually use base classes is fairly small right now

Some of these are WebIDL-based parent classes, but I don't think this is small:
https://searchfox.org/mozilla-central/search?q=class.%2Bextends&path=*.*js&regexp=true

Can you elaborate on why JSDoc comments would be invalid?

class A {
  /** @param {string} foo */
  do(foo) {}
}

This would be the source of the base class before removal of foo. After removal, the JSDoc referencing a non-existing argument is invalid.

Right but that jsdoc comment won't be there of course.

Sure, but we're a long ways off being able to use TypeScript across the codebase.

It looks more feasible to me than a few weeks ago, now that I have PoC in bug 1869678. Besides what's already there, I also have our [ChromeOnly] WebIDL definitions converted to a typescript lib-dom.d.ts locally (using a slightly patched TypeScript-DOM-lib-generator). I'll write up a case study/proposal after the holiday break if things work out as expected.

With modules only maybe, I'll be interested to see that as it may fit in with my plans for the coming years. But looking at TypeScript it doesn't appear that it allows unused parameters in base classes either. See the example here where it throws an error on an unused argument in a base class despite another class making use of it.

Comment 25

[Dave Townsend [:mossop]]

So essentially the issue with unused parameters in base classes is the same as that already discussed in the mailing list. That TypeScript will throw an error if we manage to get around to using it adds some weight but is also helpful. Right now we can't easily quantify the number of unused parameters in base classes that we shouldn't remove. My intuition tells me that it is lower than the number that we should remove. And if we manage to get TypeScript stood up then it will tell us exactly the places that we were wrong making fixing fairly straightforward. So I think we're better off going ahead with the plan. I realise that the final plan isn't actually documented in this bug as it altered slightly in the mailing list discussion so here is what we're doing:

1. Via a combination of automated tooling and some manual fixups we're going to remove all parameters (and their jsdoc comments) from functions where the no-unused-vars rule fails using the planned config.
2. Then we turn on the no-unused-vars config which will error on unused parameters after any used parameters but allowing parameters that are prefixed with _.

As Mark mentioned the rule will not auto-fix as that is quite annoying in development (and also the eslint provided rule doesn't support autofixing anyway).

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b47cdc0641c
Remove some unused function arguments from a DOM test. r=dom-core,peterv
https://hg.mozilla.org/integration/autoland/rev/27503c968e94
Remove some unused arguments from webextension APIs. r=geckoview-reviewers,extension-reviewers,robwu,owlish

Comment 27

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7b47cdc0641c
https://hg.mozilla.org/mozilla-central/rev/27503c968e94

Comment 28

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (accessible).

Comment 29

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/base/content).

Comment 30

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/components/newtab).

Comment 31

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/components/pocket).

Comment 32

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/components/preferences).

Comment 33

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/components/sessionstore).

Comment 34

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/components/urlbar).

Comment 35

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (browser/components/urlbar).

Comment 36

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser/extensions/webcompat).

Comment 37

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (credential management).

Comment 38

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (credential management).

Comment 39

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (devtools).

Comment 40

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove empty destructuring patterns (devtools).

Comment 41

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (docshell).

Comment 42

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (dom).

Comment 43

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (downloads).

Comment 44

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (editor).

Comment 45

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (experiments).

Comment 46

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (extensions/permissions).

Comment 47

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (gfx).

Comment 48

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (image).

Comment 49

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (ipc).

Comment 50

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (js).

Comment 51

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (layout).

Comment 52

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (mobile/android).

Comment 53

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (modules/libjar).

Comment 54

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (modules/libpref).

Comment 55

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (netwerk).

Comment 56

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (parser).

Comment 57

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (pip).

Comment 58

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (pip).

Comment 59

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (places).

Comment 60

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (places).

Comment 61

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (remote).

Comment 62

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (remote).

Comment 63

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (search).

Comment 64

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (search).

Comment 65

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (security).

Comment 66

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (services).

Comment 67

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (storage).

Comment 68

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (telemetry).

Comment 69

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (testing).

Comment 70

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (toolkit/components/antitracking).

Comment 71

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (toolkit/components/url-classifier).

Comment 72

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (toolkit/content/widgets).

Comment 73

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (toolkit/mozapps/extensions).

Comment 74

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Fix unused function arguments (toolkit/mozapps/update) r=mossop!

Comment 75

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (tools/lint/eslint/eslint-plugin-mozilla).

Comment 76

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (tools/profiler).

Comment 77

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (uriloader).

Comment 78

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (webextensions).

Comment 79

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (webextensions).

Comment 80

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (widget).

Comment 81

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (toolkit).

Comment 82

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (browser).

Comment 83

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Remove jsdoc params for removed arguments (browser).

Comment 84

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Autofix unused function arguments (general).

Comment 85

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1955ae3e9e2
Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
https://hg.mozilla.org/integration/autoland/rev/06a05e5257d5
Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/1abbcaf91693
Autofix unused function arguments (editor). r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e48d6928bdcb
Autofix unused function arguments (experiments). r=barret
https://hg.mozilla.org/integration/autoland/rev/2cd1cc279f99
Autofix unused function arguments (extensions/permissions). r=timhuang

Comment 86

[Iulian Moraru]

Backed out for causing newtab failures related to bundles.

• Push with failures

• Failure log
  There are also this TV failures if you want to check them out before relanding this.

• Backout link

[task 2024-03-01T10:38:22.767Z] + cd /builds/worker/checkouts/gecko/browser/components/newtab
[task 2024-03-01T10:38:22.767Z] + rm -rf node_modules
[task 2024-03-01T10:38:22.768Z] + npm ci
[task 2024-03-01T10:38:23.362Z] npm WARN ERESOLVE overriding peer dependency
[task 2024-03-01T10:38:23.363Z] npm WARN While resolving: react-test-renderer@16.14.0
[task 2024-03-01T10:38:23.363Z] npm WARN Found: react@16.13.1
[task 2024-03-01T10:38:23.363Z] npm WARN node_modules/react
[task 2024-03-01T10:38:23.363Z] npm WARN   react@"16.13.1" from the root project
[task 2024-03-01T10:38:23.363Z] npm WARN   7 more (@fluent/react, airbnb-prop-types, ...)
[task 2024-03-01T10:38:23.363Z] npm WARN 
[task 2024-03-01T10:38:23.363Z] npm WARN Could not resolve dependency:
[task 2024-03-01T10:38:23.363Z] npm WARN peer react@"^16.14.0" from react-test-renderer@16.14.0
[task 2024-03-01T10:38:23.363Z] npm WARN node_modules/enzyme-adapter-react-16/node_modules/react-test-renderer
[task 2024-03-01T10:38:23.363Z] npm WARN   react-test-renderer@"^16.0.0-0" from enzyme-adapter-react-16@1.15.6
[task 2024-03-01T10:38:23.363Z] npm WARN   node_modules/enzyme-adapter-react-16
[task 2024-03-01T10:38:23.363Z] npm WARN 
[task 2024-03-01T10:38:23.363Z] npm WARN Conflicting peer dependency: react@16.14.0
[task 2024-03-01T10:38:23.363Z] npm WARN node_modules/react
[task 2024-03-01T10:38:23.363Z] npm WARN   peer react@"^16.14.0" from react-test-renderer@16.14.0
[task 2024-03-01T10:38:23.363Z] npm WARN   node_modules/enzyme-adapter-react-16/node_modules/react-test-renderer
[task 2024-03-01T10:38:23.364Z] npm WARN     react-test-renderer@"^16.0.0-0" from enzyme-adapter-react-16@1.15.6
[task 2024-03-01T10:38:23.364Z] npm WARN     node_modules/enzyme-adapter-react-16
[task 2024-03-01T10:38:25.895Z] npm WARN deprecated sinon@12.0.1: 16.1.1
[task 2024-03-01T10:38:26.203Z] 
[task 2024-03-01T10:38:26.203Z] added 590 packages, and audited 591 packages in 3s
[task 2024-03-01T10:38:26.203Z] 
[task 2024-03-01T10:38:26.203Z] 130 packages are looking for funding
[task 2024-03-01T10:38:26.203Z]   run `npm fund` for details
[task 2024-03-01T10:38:26.205Z] 
[task 2024-03-01T10:38:26.205Z] found 0 vulnerabilities
[task 2024-03-01T10:38:26.218Z] + node bin/try-runner.js
[task 2024-03-01T10:38:26.335Z] TEST-START | bundles
[task 2024-03-01T10:38:35.840Z] TEST-UNEXPECTED-FAIL | bundles | Activity Stream bundle out of date
[task 2024-03-01T10:38:35.840Z] TEST-UNEXPECTED-FAIL | bundles | about:asrouter bundle out of date
[task 2024-03-01T10:38:35.841Z] TEST-START | karma /builds/worker/checkouts/gecko/browser/components/newtab
[task 2024-03-01T10:39:00.847Z] webpack was not included as a framework in karma configuration, setting this automatically...
[task 2024-03-01T10:39:00.853Z] -----karma stdout below this line---
[task 2024-03-01T10:39:00.855Z] 
[task 2024-03-01T10:39:00.855Z] > activity-streams@1.14.3 testmc:unit
[task 2024-03-01T10:39:00.855Z] > karma start karma.mc.config.js
[task 2024-03-01T10:39:00.855Z] 
[task 2024-03-01T10:39:00.855Z] 
[task 2024-03-01T10:39:00.855Z] START:
[task 2024-03-01T10:39:00.855Z] Webpack bundling...

Comment 87

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/153146ce081c
Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
https://hg.mozilla.org/integration/autoland/rev/adba0b352699
Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs

Comment 88

[Natalia Csoregi [:nataliaCs]]

Backed out for causing node failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/d93171a594b89c79014b1451b15a1f09534af299
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=V6ku6IJMQLab1XbE2j-esw.0&revision=adba0b352699a1fc00c51a5a9beb3cf3d5b41949
• failure log: https://treeherder.mozilla.org/logviewer?job_id=449128170&repo=autoland&lineNumber=375

[task 2024-03-01T16:06:59.515Z] npm WARN ERESOLVE overriding peer dependency
[task 2024-03-01T16:06:59.516Z] npm WARN While resolving: react-test-renderer@16.14.0
[task 2024-03-01T16:06:59.516Z] npm WARN Found: react@16.13.1
[task 2024-03-01T16:06:59.516Z] npm WARN node_modules/react
[task 2024-03-01T16:06:59.516Z] npm WARN   react@"16.13.1" from the root project
[task 2024-03-01T16:06:59.516Z] npm WARN   7 more (@fluent/react, airbnb-prop-types, ...)
[task 2024-03-01T16:06:59.517Z] npm WARN 
[task 2024-03-01T16:06:59.517Z] npm WARN Could not resolve dependency:
[task 2024-03-01T16:06:59.517Z] npm WARN peer react@"^16.14.0" from react-test-renderer@16.14.0
[task 2024-03-01T16:06:59.517Z] npm WARN node_modules/enzyme-adapter-react-16/node_modules/react-test-renderer
[task 2024-03-01T16:06:59.517Z] npm WARN   react-test-renderer@"^16.0.0-0" from enzyme-adapter-react-16@1.15.6
[task 2024-03-01T16:06:59.517Z] npm WARN   node_modules/enzyme-adapter-react-16
[task 2024-03-01T16:06:59.517Z] npm WARN 
[task 2024-03-01T16:06:59.517Z] npm WARN Conflicting peer dependency: react@16.14.0
[task 2024-03-01T16:06:59.517Z] npm WARN node_modules/react
[task 2024-03-01T16:06:59.517Z] npm WARN   peer react@"^16.14.0" from react-test-renderer@16.14.0
[task 2024-03-01T16:06:59.517Z] npm WARN   node_modules/enzyme-adapter-react-16/node_modules/react-test-renderer
[task 2024-03-01T16:06:59.517Z] npm WARN     react-test-renderer@"^16.0.0-0" from enzyme-adapter-react-16@1.15.6
[task 2024-03-01T16:06:59.517Z] npm WARN     node_modules/enzyme-adapter-react-16
[task 2024-03-01T16:07:02.771Z] npm WARN deprecated sinon@12.0.1: 16.1.1
[task 2024-03-01T16:07:03.200Z] 
[task 2024-03-01T16:07:03.200Z] added 590 packages, and audited 591 packages in 4s
[task 2024-03-01T16:07:03.200Z] 
[task 2024-03-01T16:07:03.200Z] 130 packages are looking for funding
[task 2024-03-01T16:07:03.200Z]   run `npm fund` for details
[task 2024-03-01T16:07:03.202Z] 
[task 2024-03-01T16:07:03.202Z] found 0 vulnerabilities
[task 2024-03-01T16:07:03.217Z] + node bin/try-runner.js
[task 2024-03-01T16:07:03.361Z] TEST-START | bundles
[task 2024-03-01T16:07:14.308Z] TEST-UNEXPECTED-FAIL | bundles | about:asrouter bundle out of date

Comment 89

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674f080c4132
Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/fad778a2abfd
Autofix unused function arguments (editor). r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e4bc66038111
Autofix unused function arguments (experiments). r=barret
https://hg.mozilla.org/integration/autoland/rev/74d97829e17b
Autofix unused function arguments (extensions/permissions). r=timhuang

Comment 90

[Sergey Galich [:serg]]

Attachment: Bug 1864896: Polishing autofix of unused function arguments (credential management).

Depends on D202958

Comment 91

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32438d22907c
Autofix unused function arguments (ipc). r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/a04b7236ed7a
Autofix unused function arguments (modules/libjar). r=valentin
https://hg.mozilla.org/integration/autoland/rev/eace859b61a8
Autofix unused function arguments (modules/libpref). r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/89aaa62ca38e
Autofix unused function arguments (netwerk). r=kershaw,cookie-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/f9ffc7a620f6
Autofix unused function arguments (places). r=places-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/cff0ad593c6f
Remove jsdoc params for removed arguments (places). r=places-reviewers,Standard8

Comment 92

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2c7e0410903
Autofix unused function arguments (remote). r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/1282ba5b87fa
Remove jsdoc params for removed arguments (remote). r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/346d01e58886
Autofix unused function arguments (search). r=search-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/14d89bbe01dd
Remove jsdoc params for removed arguments (search). r=search-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/43590688afb0
Autofix unused function arguments (security). r=keeler
https://hg.mozilla.org/integration/autoland/rev/ad3eae3f8eb5
Autofix unused function arguments (storage). r=asuth
https://hg.mozilla.org/integration/autoland/rev/a996fce8b781
Autofix unused function arguments (telemetry). r=chutten
https://hg.mozilla.org/integration/autoland/rev/89199aa6a41f
Autofix unused function arguments (toolkit/components/antitracking). r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/d5b31dfc3ce7
Autofix unused function arguments (toolkit/components/url-classifier). r=dimi
https://hg.mozilla.org/integration/autoland/rev/46e3ab5ca2e1
Autofix unused function arguments (toolkit/content/widgets). r=pip-reviewers,reusable-components-reviewers,kpatenio,tgiles
https://hg.mozilla.org/integration/autoland/rev/c86c685ccd56
Autofix unused function arguments (tools/lint/eslint/eslint-plugin-mozilla). r=Standard8
https://hg.mozilla.org/integration/autoland/rev/ac7b674e512d
Autofix unused function arguments (tools/profiler). r=profiler-reviewers,julienw

Comment 93

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/674f080c4132
https://hg.mozilla.org/mozilla-central/rev/fad778a2abfd
https://hg.mozilla.org/mozilla-central/rev/e4bc66038111
https://hg.mozilla.org/mozilla-central/rev/74d97829e17b

Comment 94

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17be15b00ed6
Autofix unused function arguments (widget). r=spohl
https://hg.mozilla.org/integration/autoland/rev/73dfdbaaabe3
Autofix unused function arguments (docshell). r=nika
https://hg.mozilla.org/integration/autoland/rev/3c9944598f6c
Autofix unused function arguments (js). r=jandem
https://hg.mozilla.org/integration/autoland/rev/2880fbdc5ca5
Autofix unused function arguments (layout). r=dshin
https://hg.mozilla.org/integration/autoland/rev/6b31316615e4
Autofix unused function arguments (parser). r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bb643e585fb3
Autofix unused function arguments (pip). r=pip-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/832fed5aae75
Remove jsdoc params for removed arguments (pip). r=pip-reviewers,niklas
https://hg.mozilla.org/integration/autoland/rev/c204f4699549
Autofix unused function arguments (services). r=markh,sync-reviewers

Comment 95

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/32438d22907c
https://hg.mozilla.org/mozilla-central/rev/a04b7236ed7a
https://hg.mozilla.org/mozilla-central/rev/eace859b61a8
https://hg.mozilla.org/mozilla-central/rev/89aaa62ca38e
https://hg.mozilla.org/mozilla-central/rev/f9ffc7a620f6
https://hg.mozilla.org/mozilla-central/rev/cff0ad593c6f
https://hg.mozilla.org/mozilla-central/rev/a2c7e0410903
https://hg.mozilla.org/mozilla-central/rev/1282ba5b87fa
https://hg.mozilla.org/mozilla-central/rev/346d01e58886
https://hg.mozilla.org/mozilla-central/rev/14d89bbe01dd
https://hg.mozilla.org/mozilla-central/rev/43590688afb0
https://hg.mozilla.org/mozilla-central/rev/ad3eae3f8eb5
https://hg.mozilla.org/mozilla-central/rev/a996fce8b781
https://hg.mozilla.org/mozilla-central/rev/89199aa6a41f
https://hg.mozilla.org/mozilla-central/rev/d5b31dfc3ce7
https://hg.mozilla.org/mozilla-central/rev/46e3ab5ca2e1
https://hg.mozilla.org/mozilla-central/rev/c86c685ccd56
https://hg.mozilla.org/mozilla-central/rev/ac7b674e512d
https://hg.mozilla.org/mozilla-central/rev/17be15b00ed6
https://hg.mozilla.org/mozilla-central/rev/73dfdbaaabe3
https://hg.mozilla.org/mozilla-central/rev/3c9944598f6c
https://hg.mozilla.org/mozilla-central/rev/2880fbdc5ca5
https://hg.mozilla.org/mozilla-central/rev/6b31316615e4
https://hg.mozilla.org/mozilla-central/rev/bb643e585fb3
https://hg.mozilla.org/mozilla-central/rev/832fed5aae75
https://hg.mozilla.org/mozilla-central/rev/c204f4699549

Comment 96

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82e9d69d4c83
Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
https://hg.mozilla.org/integration/autoland/rev/8e7bfcf84651
Autofix unused function arguments (browser/components/urlbar). r=mak
https://hg.mozilla.org/integration/autoland/rev/9fb6bc7e6180
Remove jsdoc params for removed arguments (browser/components/urlbar). r=mak
https://hg.mozilla.org/integration/autoland/rev/069af7518db5
Autofix unused function arguments (downloads). r=mtigley
https://hg.mozilla.org/integration/autoland/rev/d1e884636a6f
Autofix unused function arguments (image). r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/a635cd6e99ff
Autofix unused function arguments (uriloader). r=mtigley

Comment 97

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/82e9d69d4c83
https://hg.mozilla.org/mozilla-central/rev/8e7bfcf84651
https://hg.mozilla.org/mozilla-central/rev/9fb6bc7e6180
https://hg.mozilla.org/mozilla-central/rev/069af7518db5
https://hg.mozilla.org/mozilla-central/rev/d1e884636a6f
https://hg.mozilla.org/mozilla-central/rev/a635cd6e99ff

Comment 98

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b88db147fe06
Autofix unused function arguments (accessible). r=Jamie
https://hg.mozilla.org/integration/autoland/rev/7c42528aa6cc
Autofix unused function arguments (dom). r=emilio,media-playback-reviewers,dom-storage-reviewers,padenot,janv
https://hg.mozilla.org/integration/autoland/rev/0599520fd021
Autofix unused function arguments (gfx). r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/5d9e45e142e6
Autofix unused function arguments (mobile/android). r=geckoview-reviewers,extension-reviewers,zombie,m_kato

Comment 99

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b88db147fe06
https://hg.mozilla.org/mozilla-central/rev/7c42528aa6cc
https://hg.mozilla.org/mozilla-central/rev/0599520fd021
https://hg.mozilla.org/mozilla-central/rev/5d9e45e142e6

Comment 100

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a718dab28ae8
Autofix unused function arguments (credential management). r=credential-management-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/370cc10f581f
Remove jsdoc params for removed arguments (credential management). r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/c34ae867e9b9
Polishing autofix of unused function arguments (credential management). r=credential-management-reviewers,dimi

Comment 101

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a718dab28ae8
https://hg.mozilla.org/mozilla-central/rev/370cc10f581f
https://hg.mozilla.org/mozilla-central/rev/c34ae867e9b9

Comment 102

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7a163a4bb1b
Autofix unused function arguments (webextensions). r=extension-reviewers,zombie
https://hg.mozilla.org/integration/autoland/rev/8586fda0db02
Remove jsdoc params for removed arguments (webextensions). r=extension-reviewers,zombie
https://hg.mozilla.org/integration/autoland/rev/8a5614920eab
Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
https://hg.mozilla.org/integration/autoland/rev/0f30b92ccb00
Remove empty destructuring patterns (devtools). r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a01a55c90524
Autofix unused function arguments (testing). r=webdriver-reviewers,perftest-reviewers,jmaher,devtools-reviewers,sparky

Comment 103

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c7a163a4bb1b
https://hg.mozilla.org/mozilla-central/rev/8586fda0db02
https://hg.mozilla.org/mozilla-central/rev/8a5614920eab
https://hg.mozilla.org/mozilla-central/rev/0f30b92ccb00
https://hg.mozilla.org/mozilla-central/rev/a01a55c90524

Comment 104

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf755d27fb69
Fix unused function arguments (toolkit/mozapps/update) r=application-update-reviewers,mossop,nalexander

Comment 105

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/cf755d27fb69

Comment 106

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4cec6f02a26
Autofix unused function arguments (browser/components/sessionstore). r=sessionstore-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/ebc27262108a
Autofix unused function arguments (browser/components/pocket). r=thecount
https://hg.mozilla.org/integration/autoland/rev/9b880a2334b1
Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
https://hg.mozilla.org/integration/autoland/rev/3ff6e7233c5b
Remove jsdoc params for removed arguments (browser). r=mconley,migration-reviewers

Comment 107

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff224401ffe7
Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
https://hg.mozilla.org/integration/autoland/rev/ab638a47c224
Autofix unused function arguments (browser/extensions/webcompat). r=webcompat-reviewers,twisniewski
https://hg.mozilla.org/integration/autoland/rev/bdda730bd146
Autofix unused function arguments (toolkit/mozapps/extensions). r=zombie
https://hg.mozilla.org/integration/autoland/rev/4dc9d01c1d35
Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer
https://hg.mozilla.org/integration/autoland/rev/7305404462c0
Autofix unused function arguments (general). r=nika,jfkthame,ckerschb

Comment 108

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4cec6f02a26
https://hg.mozilla.org/mozilla-central/rev/ebc27262108a
https://hg.mozilla.org/mozilla-central/rev/9b880a2334b1
https://hg.mozilla.org/mozilla-central/rev/3ff6e7233c5b

Comment 109

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ff224401ffe7
https://hg.mozilla.org/mozilla-central/rev/ab638a47c224
https://hg.mozilla.org/mozilla-central/rev/bdda730bd146
https://hg.mozilla.org/mozilla-central/rev/4dc9d01c1d35
https://hg.mozilla.org/mozilla-central/rev/7305404462c0

Comment 110

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Fix unused arguments for credential management. r=sgalich!

Comment 111

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Fix unused arguments for accessibility. r=jamie!

Comment 112

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Fix more unused arguments in browser and toolkit. r=mconley!

Comment 113

[Dave Townsend [:mossop]]

Attachment: Bug 1864896: Fix more unused arguments. r=KrisWright!,smaug!,valentin!

Comment 114

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a07b3efb7f4b
Fix unused arguments for credential management. r=dimi
https://hg.mozilla.org/integration/autoland/rev/c42f1ab7f7c5
Fix unused arguments for accessibility. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/029ec74cbc4a
Fix more unused arguments in browser and toolkit. r=mconley,webcompat-reviewers,places-reviewers,Standard8,denschub,twisniewski
https://hg.mozilla.org/integration/autoland/rev/42e0c42e5e1c
Fix more unused arguments. r=KrisWright,smaug,valentin,necko-reviewers

Comment 115

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79b454f01f93
Enable unused argument lint rule. r=Standard8,perftest-reviewers,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,robwu,sparky,issammani,sgalich,owlish,migration-reviewers,mconley

Comment 116

[Dave Townsend [:mossop]]

Attachment: Bug 1864896 Remove additional unused function arguments.

Comment 117

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03dd6d250e9b
Remove additional unused function arguments.

Comment 118

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a07b3efb7f4b
https://hg.mozilla.org/mozilla-central/rev/c42f1ab7f7c5
https://hg.mozilla.org/mozilla-central/rev/029ec74cbc4a
https://hg.mozilla.org/mozilla-central/rev/42e0c42e5e1c
https://hg.mozilla.org/mozilla-central/rev/79b454f01f93
https://hg.mozilla.org/mozilla-central/rev/03dd6d250e9b