Closed Bug 1865068 Opened 1 year ago Closed 1 year ago

clean up nsIMsgAccountManager

Categories

(MailNews Core :: Account Manager, defect)

defect

Tracking

(thunderbird_esr115 wontfix)

RESOLVED FIXED
121 Branch
Tracking Status
thunderbird_esr115 --- wontfix

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

nsIMsgAccountManager is many times using string types that can cause issues.
E.g. a MailServices.accounts.findServer call from js for a non-ascii username/hostname will not work as it should.

I'll clean them up all at once and make it consistent.
The method names that start with capital letter is also ugly for js usage.

Fix string type and correct method name capitalization.

find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/FindServerIndex(/findServerIndex(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/FindAccountForServer(/findAccountForServer(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/WriteToFolderCache(/writeToFolderCache(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/CleanupOnExit(/cleanupOnExit(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/SetFolderDoingEmptyTrash(/setFolderDoingEmptyTrash(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/GetEmptyTrashInProgress(/getEmptyTrashInProgress(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/SetFolderDoingCleanupInbox(/setFolderDoingCleanupInbox(/g' {} \;
find . -type f -not -path "*.hg*" -not -name "*.cpp" -not -name "*.h" -exec sed -i 's/GetCleanupInboxInProgress(/getCleanupInboxInProgress(/g' {} \;
Status: NEW → ASSIGNED
Target Milestone: --- → 121 Branch

Pushed by ikey@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/ae2ec9897473
Improve nsIMsgAccountManager idl. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: