1865087 - Refactor some parts of PlacesTransactions

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

I have a few ideas in mind to simplify solving Bug 1857882, that are not strictly part of that fix.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1865087 - Change PlacesTransaction.batch() to only accept an array of transactions. r=places-reviewers

Rather than accepting either an array or an async function, make it only accept
an array. This simplifies the internals for future refactoring, and avoids
depending on async functions created in other globals.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1865087 - Add optional logging to PlacesTransactions. r=places-reviewers

Depends on D193813

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1865087 - Track batching transactions differently in PlacesTransactions. r=places-reviewers

Rather than keeping around properties tracking batches, straight annotate
transact() calls that happen inside a batch. This simplified things a bit and
potentially allows to move the component to a single Enqueuer.

Depends on D193814

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e680863304ae
Change PlacesTransaction.batch() to only accept an array of transactions. r=places-reviewers,daisuke
https://hg.mozilla.org/integration/autoland/rev/903654c94b22
Add optional logging to PlacesTransactions. r=places-reviewers,daisuke
https://hg.mozilla.org/integration/autoland/rev/bb4605391d57
Track batching transactions differently in PlacesTransactions. r=places-reviewers,daisuke

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e680863304ae
https://hg.mozilla.org/mozilla-central/rev/903654c94b22
https://hg.mozilla.org/mozilla-central/rev/bb4605391d57