Closed Bug 1865103 Opened 4 months ago Closed 3 months ago

Ship ArrayBuffer.prototype.transfer proposal

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
relnote-firefox --- 122+
firefox122 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(4 files)

No description provided.

Andre: Is there anything you see blocking us from just unflagging this now?

Flags: needinfo?(andrebargull)

I think it should be okay to ship the implementation.

Flags: needinfo?(andrebargull)
Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED

Update the jstests skip list for SharedArrayBuffer tests as well.

Special handling is required for the two transfer methods, as they detach the
array buffer, which breaks future tests. This patch adds gStatefulProperties
which are those that cannot be invoked without changing object state in such a
way as to break the test harness.

Depends on D195574

Attachment #9367383 - Attachment description: Bug 1865103 - Update test_xrayToJS r?nika → Bug 1865103 - Update test_xrayToJS r?peterv
Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/f89fa88d7606
Allow ArrayBuffer.prototype.transfer to be enabled outside of nightly r=anba
https://hg.mozilla.org/mozilla-central/rev/b5909f5010c7
Enable ArrayBuffer.prototype.transfer by default r=anba
https://hg.mozilla.org/mozilla-central/rev/7eaa2d12be9f
Remove feature checks from tests r=anba
https://hg.mozilla.org/mozilla-central/rev/eff46450e868
Update test_xrayToJS r=peterv

:mgaudet could you consider nominating this for a release note? (Process info)

Flags: needinfo?(mgaudet)

Release Note Request (optional, but appreciated)
[Why is this notable]: A new web platform feature
[Affects Firefox for Android]: Yes
[Suggested wording]: "Enabled the ArrayBuffer.prototype.transfer proposal methods, which enables transferring ownership of ArrayBuffer data."
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Flags: needinfo?(mgaudet)

Thanks, added to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

:mgaudet can you confirm the expected state of this? Wondering if it in fact enabled for Fx122.
https://hg.mozilla.org/mozilla-central/diff/f89fa88d7606eabe5797e9bb9a058f151c16f637/modules/libpref/init/StaticPrefList.yaml
The pref value is false.

Flags: needinfo?(mgaudet)

So that patch merely made the pref flip possible; the flip actually happened in the next patch (https://hg.mozilla.org/mozilla-central/rev/b5909f5010c7e45247034c8147e0cc5d16f92400).

Flags: needinfo?(mgaudet)

(You can also check in console with (new ArrayBuffer(10)).transfer())

Sorry for the noise, mistake on my part

FF122 MDN docs work for this done in https://github.com/mdn/content/issues/31101. Just a release note, removing markup to indicate "experimental", and update browser compatibility data.

You need to log in before you can comment on or make changes to this bug.