1865103 - Ship ArrayBuffer.prototype.transfer proposal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Andre: Is there anything you see blocking us from just unflagging this now?

Comment 2

[André Bargull [:anba]]

I think it should be okay to ship the implementation.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1865103 - Allow ArrayBuffer.prototype.transfer to be enabled outside of nightly r?anba

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1865103 - Enable ArrayBuffer.prototype.transfer by default r?anba

Depends on D195572

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1865103 - Remove feature checks from tests r?anba

Update the jstests skip list for SharedArrayBuffer tests as well.

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1865103 - Update test_xrayToJS r?peterv

Special handling is required for the two transfer methods, as they detach the
array buffer, which breaks future tests. This patch adds gStatefulProperties
which are those that cannot be invoked without changing object state in such a
way as to break the test harness.

Depends on D195574

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Sent Intent to Ship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/LXFQsMupYYY

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f89fa88d7606
Allow ArrayBuffer.prototype.transfer to be enabled outside of nightly r=anba
https://hg.mozilla.org/mozilla-central/rev/b5909f5010c7
Enable ArrayBuffer.prototype.transfer by default r=anba
https://hg.mozilla.org/mozilla-central/rev/7eaa2d12be9f
Remove feature checks from tests r=anba
https://hg.mozilla.org/mozilla-central/rev/eff46450e868
Update test_xrayToJS r=peterv

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f89fa88d7606
https://hg.mozilla.org/mozilla-central/rev/b5909f5010c7
https://hg.mozilla.org/mozilla-central/rev/7eaa2d12be9f
https://hg.mozilla.org/mozilla-central/rev/eff46450e868

Comment 10

[Donal Meehan [:dmeehan]]

:mgaudet could you consider nominating this for a release note? (Process info)

Comment 11

[Matthew Gaudet (he/him) [:mgaudet]]

Release Note Request (optional, but appreciated)
[Why is this notable]: A new web platform feature
[Affects Firefox for Android]: Yes
[Suggested wording]: "Enabled the ArrayBuffer.prototype.transfer proposal methods, which enables transferring ownership of ArrayBuffer data."
[Links (documentation, blog post, etc)]:

• https://github.com/tc39/proposal-arraybuffer-transfer
• https://bugzilla.mozilla.org/show_bug.cgi?id=1519163

Comment 12

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

Comment 13

[Donal Meehan [:dmeehan]]

:mgaudet can you confirm the expected state of this? Wondering if it in fact enabled for Fx122.
https://hg.mozilla.org/mozilla-central/diff/f89fa88d7606eabe5797e9bb9a058f151c16f637/modules/libpref/init/StaticPrefList.yaml
The pref value is false.

Comment 14

[Matthew Gaudet (he/him) [:mgaudet]]

So that patch merely made the pref flip possible; the flip actually happened in the next patch (https://hg.mozilla.org/mozilla-central/rev/b5909f5010c7e45247034c8147e0cc5d16f92400).

Comment 15

[Matthew Gaudet (he/him) [:mgaudet]]

(You can also check in console with (new ArrayBuffer(10)).transfer())

Comment 16

[Donal Meehan [:dmeehan]]

Sorry for the noise, mistake on my part

Comment 17

[Hamish Willee]

FF122 MDN docs work for this done in https://github.com/mdn/content/issues/31101. Just a release note, removing markup to indicate "experimental", and update browser compatibility data.