1865119 - nsIPrincipal::EqualsURI name misleading. Should be called nsIPrincipal::EqualsURIExceptRef

Status: NEW

(Core :: Security: CAPS, task)

Description

[Manuel Bucher [:manuel]]

Misleading, because there exists a nsIURI::Equals and nsIURI::EqualsExceptRef function.

The nsIURI::EqualsExceptRef function is called in BasePrincipal: /caps/BasePrincipal.cpp#587,594

Neither the function nor the comment hints to that: /caps/nsIPrincipal.idl#90-95

/*
 * Returns whether the Principals URI is equal to the other URI
 *
 * May be called from any thread.
 */
boolean equalsURI(in nsIURI aOtherURI);

Comment 1

[Valentin Gosu [:valentin] (he/him)]

I think just adding a comment to the IDL stating that the ref doesn't affect equality with the principal should be enough.