Clarify history high-water mark behavior when users disconnect sync
Categories
(Application Services :: Places, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: markh, Unassigned)
Details
From github: https://github.com/mozilla/application-services/issues/2445.
Currently, resetting history storage via
HistoryStore::resetdoes not clear the deletion high water mark. This means that, if they sign out then sign back in with the same account (or a node reassignment happens), we won't sync down any deleted visits. This is very much desirable, and the reason why we introduced the HWM.We'll also ignore all visits before the last clear time if the user:
- Disables history sync by unchecking the "History" checkbox, then enables it again later.
- Signs out, then signs in with a different account.
We probably want to keep the HWM in the disable case, too, since it's still the same history. That said, we also advise folks to try disabling and re-enabling if they run into issues syncing, including missing history...and we don't keep bookmark tombstones around after disconnecting, so keeping the HWM feels inconsistent with that.
However, we probably do want to delete it in the different account case. Otherwise, we won't sync down any visits from their new account from before they cleared history while connected to their old account (try saying that five times fast! :stuck_out_tongue_closed_eyes:).
I think either behavior can be correct, and erring on the side of keeping the HWM is a safe choice. But it's something I noticed while working on #2250, and wanted to bring up to discuss!
┆Issue is synchronized with this Jira Task
┆Epic: Important backlog
Change performed by the Move to Bugzilla add-on.
Description
•