Crash in [@ nsWindow::ResumeCompositorImpl]
Categories
(Core :: Widget: Gtk, defect, P3)
Tracking
()
People
(Reporter: gsvelto, Assigned: stransky)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr115+
|
Details | Review |
Crash report: https://crash-stats.mozilla.org/report/index/d9190959-6e32-46e1-9ed5-85a740231111
MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(mCompositorWidgetDelegate)
Top 10 frames of crashing thread:
0 libxul.so nsWindow::ResumeCompositorImpl widget/gtk/nsWindow.cpp:6701
1 libxul.so nsWindow::ResumeCompositorFlickering widget/gtk/nsWindow.cpp:6686
2 libxul.so mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void const xpcom/threads/nsThreadUtils.h:1164
2 libxul.so std::__invoke_impl<void, mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/invoke.h:60
2 libxul.so std::__invoke<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/invoke.h:95
2 libxul.so std::__apply_impl<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/tuple:1678
2 libxul.so std::apply<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/tuple:1687
2 libxul.so mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void xpcom/threads/nsThreadUtils.h:1162
2 libxul.so mozilla::detail::RunnableMethodImpl<nsWindow*, void xpcom/threads/nsThreadUtils.h:1213
3 libxul.so mozilla::RunnableTask::Run xpcom/threads/TaskController.cpp:549
This appears to be an issue similar to bug 1784336 but following a different code-path that is not guarded by the fix introduced to address that bug.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
We pause compositor for scale changes to avoid flickering during repaint.
If compositor is deleted during the pause, don't try to resume it.
Just flip it back to enabled and let SetCompositorWidgetDelegate() or map event to resume it.
Comment 4•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Comment 5•1 year ago
|
||
The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox121
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 6•1 year ago
|
||
Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio
Beta/Release Uplift Approval Request
- User impact if declined: Wayland users may see Firefox crash if Firefox window is moved across monitors with different scale setup (for instance laptop + external monitor).
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor tweak in Wayland resume code.
- String changes made/needed:
- Is Android affected?: No
Comment 7•1 year ago
|
||
Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio
Approved for 121.0b5. Adding an ESR115 nomination too since we're seeing some crash volume from there as well.
Updated•1 year ago
|
Comment 9•1 year ago
|
||
Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio
Approved for 115.6esr.
Comment 10•1 year ago
|
||
uplift |
Updated•1 year ago
|
Description
•