1865302 - Crash in [@ nsWindow::ResumeCompositorImpl]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/d9190959-6e32-46e1-9ed5-85a740231111

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(mCompositorWidgetDelegate)

Top 10 frames of crashing thread:

0  libxul.so  nsWindow::ResumeCompositorImpl  widget/gtk/nsWindow.cpp:6701
1  libxul.so  nsWindow::ResumeCompositorFlickering  widget/gtk/nsWindow.cpp:6686
2  libxul.so  mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void  const  xpcom/threads/nsThreadUtils.h:1164
2  libxul.so  std::__invoke_impl<void, mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void   /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/invoke.h:60
2  libxul.so  std::__invoke<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void   /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/invoke.h:95
2  libxul.so  std::__apply_impl<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void   /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/tuple:1678
2  libxul.so  std::apply<mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void   /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/tuple:1687
2  libxul.so  mozilla::detail::RunnableMethodArguments<>::apply<nsWindow, void   xpcom/threads/nsThreadUtils.h:1162
2  libxul.so  mozilla::detail::RunnableMethodImpl<nsWindow*, void   xpcom/threads/nsThreadUtils.h:1213
3  libxul.so  mozilla::RunnableTask::Run  xpcom/threads/TaskController.cpp:549

This appears to be an issue similar to bug 1784336 but following a different code-path that is not guarded by the fix introduced to address that bug.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1865302 [Linux] Postpone compositor resume if we're missing mCompositorWidgetDelegate r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio

We pause compositor for scale changes to avoid flickering during repaint.
If compositor is deleted during the pause, don't try to resume it.
Just flip it back to enabled and let SetCompositorWidgetDelegate() or map event to resume it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0bda3471d44
[Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r=emilio

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a0bda3471d44

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Wayland users may see Firefox crash if Firefox window is moved across monitors with different scale setup (for instance laptop + external monitor).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor tweak in Wayland resume code.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio

Approved for 121.0b5. Adding an ESR115 nomination too since we're seeing some crash volume from there as well.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed346a422fd3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9364535 [details]
Bug 1865302 [Linux] Don't resume compositor if we're missing mCompositorWidgetDelegate r?emilio

Approved for 115.6esr.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/928491e69781