Restrict some webgpu limits
Categories
(Core :: Graphics: WebGPU, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox121 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Some drivers advertise very high limits for some things like maximum bindings of some kind per shader stage. That's great but:
- I don't trust all drivers with to keep up with their optimism
- The CTS sometimes goes "OH you can bind 2147483648 uniform buffers? Hold my bear while I verify how you behave around the limit.
- That causes all sorts of resource exhaustion issues on CI, including time.
- It causes some chunks to hit the logging limit on CI, so no parsed logs.
- Some of these limits being pretty small for a lot of GPUs, authors have to target reasonable limits so we don't have to let them the bind 2147483648 uniform buffers. if we cap it to something that is already way higher than useful but reasonable (like 256), it removes a little bit of fingerprinting potential.
Assignee | ||
Comment 1•8 months ago
|
||
Some GPUs/drivers advertise very high limits (many many more orders of magnitudes than other GPUs). These high numbers cause the test suite to generate tests that are so intense that they cause all sorts of resource exhaustions, it's also a potential fingerprinting surface so lets cap them to something reasonable.
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/066e630d3ddf Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d8a8fd9c20d Fix typo and hopefully unbust builds. a=bustage-fix CLOSED TREE
Comment 4•8 months ago
|
||
Backed out for causing build bustages.
Failure logs:
- typo: https://treeherder.mozilla.org/logviewer?job_id=436677725&repo=autoland
- mismatched types: https://treeherder.mozilla.org/logviewer?job_id=436678562&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/75a79792f237f308abbf254eee87ecefcb280ec1
Comment 5•8 months ago
|
||
Apologies for the back-and-forth. I've fixed the compilation issues in landing now; ran my own Try push (try:29dc539c8550
) to ensure that such was the case.
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19ae48adbcb0 Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler
Comment 7•8 months ago
|
||
Backed out for causing build bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/54ef8e104c9717ff958756d5644c9e9a7cc08292
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8df753f9062d Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler
Comment 9•8 months ago
|
||
bugherder |
Updated•8 months ago
|
Description
•