1865344 - Restrict some webgpu limits

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Description

[Nicolas Silva [:nical]]

Some drivers advertise very high limits for some things like maximum bindings of some kind per shader stage. That's great but:

• I don't trust all drivers with to keep up with their optimism
• The CTS sometimes goes "OH you can bind 2147483648 uniform buffers? Hold my bear while I verify how you behave around the limit.
  • That causes all sorts of resource exhaustion issues on CI, including time.
  • It causes some chunks to hit the logging limit on CI, so no parsed logs.
• Some of these limits being pretty small for a lot of GPUs, authors have to target reasonable limits so we don't have to let them the bind 2147483648 uniform buffers. if we cap it to something that is already way higher than useful but reasonable (like 256), it removes a little bit of fingerprinting potential.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1865344 - Cap a few WebGPU limits to reasonable values. r=#webgpu-reviewers

Some GPUs/drivers advertise very high limits (many many more orders of magnitudes than other GPUs). These high numbers cause the test suite to generate tests that are so intense that they cause all sorts of resource exhaustions, it's also a potential fingerprinting surface so lets cap them to something reasonable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/066e630d3ddf
Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d8a8fd9c20d
Fix typo and hopefully unbust builds. a=bustage-fix CLOSED TREE

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=066e630d3ddf24062e3abb12785b7eb724b164ec&selectedTaskRun=Z9spz-mjTXGVut62gJ-S9A.0

and:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5d8a8fd9c20dac5900083de334cbe03451f8a720&selectedTaskRun=LJcqpwJSR-2TbCxTI8Yx8g.0

Failure logs:

• typo: https://treeherder.mozilla.org/logviewer?job_id=436677725&repo=autoland
• mismatched types: https://treeherder.mozilla.org/logviewer?job_id=436678562&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/75a79792f237f308abbf254eee87ecefcb280ec1

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Apologies for the back-and-forth. I've fixed the compilation issues in landing now; ran my own Try push (try:29dc539c8550) to ensure that such was the case.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ae48adbcb0
Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/54ef8e104c9717ff958756d5644c9e9a7cc08292

Push with failures

Failure log -> error[E0308]: mismatched types

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8df753f9062d
Cap a few WebGPU limits to reasonable values. r=webgpu-reviewers,ErichDonGubler

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8df753f9062d