Closed Bug 1865381 Opened 7 months ago Closed 4 months ago

Selenium atom "Get Visible Text" ignores slot value for web component without custom text

Categories

(Remote Protocol :: Marionette, defect, P3)

defect
Points:
3

Tracking

(firefox124 fixed)

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

In the following case the Selenium atom Get Visible Text has to return the value foobar because the default slot value is shown as well, but it only returns bar.

      <script>
        class TestContainer extends HTMLElement {
          connectedCallback() {
            this.attachShadow({ mode: 'open' });
            this.shadowRoot.innerHTML = `<slot><span>foo</span></slot>bar`;
          }
        }

        customElements.define('test-container', TestContainer);
      </script>
    </head>

    <body>
      <test-container></test-container>
    </body>
Blocks: webdriver
Depends on: 1824664

I've filed the Selenium issue as: https://github.com/SeleniumHQ/selenium/issues/13206

At the moment it's not blocking us, so as agreed on it's P3 for now.

Severity: -- → S3
Priority: -- → P3

The work on bug 1865359 will fix that bug as well.

Depends on: 1865359

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #1)

I've filed the Selenium issue as: https://github.com/SeleniumHQ/selenium/issues/13206

This is now fixed. Based on that we need an update of the Selenium atoms again. Therefore I created https://github.com/w3c/webdriver/issues/1783.

I've opened a PR for the webdriver repository to bump the Selenium atoms revision: https://github.com/w3c/webdriver/pull/1784

The WebDriver classic PR got merged, as such we can land a patch to update the atoms.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Blocks: 1743116
Points: --- → 3
Whiteboard: [webdriver:m10]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93a90f93c765
[wdspec] Fix escaping in test_shadow_root_slot[default hidden]. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/4841b6b6e4f2
[marionette] Update Selenium atoms to 21560a497470f0c769931c17fa9803c6cddf6f1c. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44549 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m10] → [webdriver:m10], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m10], [wptsync upstream] → [webdriver:m10][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: