1865452 - Shopping - Remove Crossfade animation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Shopping, task, P2)

Description

[Noah Bond [:007]]

As mentioned in Bug 1858020, there is a visual bug in the bottom sheet caused by using a Crossfade wrapper to handle the state change animations. As part of this ticket, remove the Crossfade until we can find a proper fix to have the animation without the bug.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1865452 - Remove review checker crossfade (#4534)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/4353524a52c791f7955cefcf1d93db3d2a42241e
[main] Bug 1865452 - Remove review checker crossfade

Comment 3

[Rahul Sainani [:rsainani]]

Note for QE : Check Bug 1858020 for the visual defect that used to appear and STR.

Comment 4

[Chris Peterson [:cpeterson]]

Rahul, should we uplift this fix to Beta 121? Or do you recommend it ride the trains with 122?

Comment 5

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 122.0a1 from 11/22 with Google Pixel 6 (Android 14), and Samsung Galaxy Note 8 (Android 9), that the crossfade does not have any animation.

Comment 6

[Rahul Sainani [:rsainani]]

Chris, we can uplift this, now that it's verified on nightly.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1865452 - Remove review checker crossfade (backport #4534) (#4560)

Comment 8

[Rahul Sainani [:rsainani]]

Comment on attachment 9364939 [details] [review]
[mozilla-mobile/firefox-android] Bug 1865452 - Remove review checker crossfade (backport #4534) (#4560)

Beta/Release Uplift Approval Request

• User impact if declined: They would see the shadow pop bug on the sides of the card when transitioning from loading to product analysis state.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Provided in the bug.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's simply removing a compose UI element that adds animation
• String changes made/needed: no
• Is Android affected?: Yes

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9364939 [details] [review]
[mozilla-mobile/firefox-android] Bug 1865452 - Remove review checker crossfade (backport #4534) (#4560)

Approved for Fenix 121.0b2

Comment 10

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/a1da855e19ab0cf56805479b5bcd43a36ec1c77f
[releases_v121] Bug 1865452 - Remove review checker crossfade

Comment 11

[Mira Lobontiu (Android QA)]

Verified as fixed on the Beta 121.0b2 build, with Lenovo tab M10 (Android 10).